Skip to content

Conversation

@mrunalhirve128
Copy link
Contributor

@mrunalhirve128 mrunalhirve128 commented Nov 3, 2025

Adding agentic auth for Agent Framework

Copilot AI review requested due to automatic review settings November 3, 2025 22:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the add_tool_servers_to_agent method to enforce authorization requirements and add token exchange functionality. The changes make authentication mandatory and add automatic token exchange when an auth token is not provided.

  • Makes auth and turn_context required parameters instead of optional
  • Adds token exchange logic using auth.exchange_token() when auth_token is not provided
  • Imports utility functions get_ppapi_token_scope and get_use_environment_id
Comments suppressed due to low confidence (2)

libraries/microsoft-agents-a365-tooling-extensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py:1

  • The copyright header format is incorrect. According to Microsoft's standard format, it should be '# Copyright (c) Microsoft Corporation.' followed by '# Licensed under the MIT License.' on the next line.
# Copyright (c) Microsoft. All rights reserved.

libraries/microsoft-agents-a365-tooling-extensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py:20

  • Import of 'get_use_environment_id' is not used.
from microsoft_agents_a365.tooling.utils.utility import (
    get_ppapi_token_scope,
    get_use_environment_id,
)

@mrunalhirve128
Copy link
Contributor Author

@copilot open a new pull request to apply changes based on the comments in this thread

Copy link
Contributor

Copilot AI commented Nov 3, 2025

@mrunalhirve128 I've opened a new pull request, #11, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI review requested due to automatic review settings November 3, 2025 22:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

libraries/microsoft-agents-a365-tooling-extensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py:1

  • The copyright header is missing the MIT License line. It should include both the copyright and license information according to the project standards. The header should be:\npython\n# Copyright (c) Microsoft Corporation.\n# Licensed under the MIT License.\n
# Copyright (c) Microsoft. All rights reserved.

pontemonti
pontemonti previously approved these changes Nov 4, 2025
Copilot AI review requested due to automatic review settings November 4, 2025 18:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@mrunalhirve128 mrunalhirve128 merged commit 6678329 into main Nov 4, 2025
14 checks passed
@pontemonti pontemonti deleted the users/mrunalhirve/AFAgenticauth branch December 5, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants