Enforce linting and fix all existing errors. #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the copyright notice regex pattern in the Ruff linter configuration to match the specification documented in CLAUDE.md. The change enforces the two-line Microsoft MIT License copyright header format instead of the previous single-line "All rights reserved" format.
Changes:
- Updated
notice-rgxpattern in[tool.ruff.lint.flake8-copyright]to match the two-line copyright header format specified in CLAUDE.md - Updated the configuration comment to reference the CLAUDE.md specification
…r context on exceptions
tests/observability/extensions/semantickernel/test_wrapper_semantic_kernel.py
Outdated
Show resolved
Hide resolved
tests/observability/extensions/openai/test_wrapper_openaiagents.py
Outdated
Show resolved
Hide resolved
tests/observability/extensions/langchain/test_wrapper_langchain.py
Outdated
Show resolved
Hide resolved
...bservability-core/microsoft_agents_a365/observability/core/trace_processor/span_processor.py
Outdated
Show resolved
Hide resolved
pontemonti
changed the title
mengyimicro
approved these changes
Jan 24, 2026
tmlsousa
approved these changes
Jan 24, 2026
nikhilNava
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting errors were being ignored due to continue-on-error being set to true for the linting step of the PR workflow.
When correcting that, we discovered a number of issues.
The format of copyright headers was a known issue -
pyproject.tomlwas specifying the old format whileCLAUDE.mdhad the correct format. When fixingpyproject.toml, we saw some errors related to copyright headers - less than 20 files that needed fixing. However, Claude had mentioned there were over 100 files that needed changing. With some additional prompting, we found issues with how the linting was invoked - led to a fix to the PR workflow - as well as missing information in the package-specificpyproject.tomlfiles. After fixing those things we were able to run linting correctly and we fixed all the copyright headers.