Skip to content

Conversation

@pontemonti
Copy link
Contributor

  • Initial plan

  • Add support for custom MCP server URLs

  • Add comprehensive tests for custom MCP server URL support

  • Remove unnecessary hasattr check in exception handler

  • Simplify custom URL checks by removing redundant strip calls

  • Improve exception handling and clarify test comments

  • Refactor to consistently store URLs in the url field

  • Use 'url' field consistently in both manifest and gateway responses

  • Refactor gateway parsing to match manifest logic and improve variable naming

  • Fix formatting: remove extra blank line in test

  • Rename custom_url to endpoint for better clarity

  • Remove fallback logic and use config.url directly in all tool registration services

  • Remove redundant null check for server_url in Agent Framework service

  • Use 'or' operator for cleaner fallback logic in server_name assignment

  • Add clarifying comment for server_name fallback logic

  • Fix undefined variable reference in log statement

  • Move server_name assignment outside try block to ensure it's always available in exception handler

  • Clarify comment for server_name fallback logic

  • Add server_name fallback logic in OpenAI MCP tool registration service

  • Improve variable naming consistency and add server_name fallback in Semantic Kernel service

  • Fix inconsistent server_name usage in Semantic Kernel service

  • Add server_name fallback logic in configuration service URL construction

  • Run ruff formatter to fix formatting issues

  • Update tests/tooling/test_mcp_server_configuration.py

  • Update tests/tooling/test_mcp_server_configuration.py

  • Update tests/tooling/test_mcp_server_configuration.py


* Initial plan

* Add support for custom MCP server URLs

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Add comprehensive tests for custom MCP server URL support

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Remove unnecessary hasattr check in exception handler

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Simplify custom URL checks by removing redundant strip calls

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Improve exception handling and clarify test comments

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Refactor to consistently store URLs in the url field

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Use 'url' field consistently in both manifest and gateway responses

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Refactor gateway parsing to match manifest logic and improve variable naming

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Fix formatting: remove extra blank line in test

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Rename custom_url to endpoint for better clarity

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Remove fallback logic and use config.url directly in all tool registration services

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Remove redundant null check for server_url in Agent Framework service

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Use 'or' operator for cleaner fallback logic in server_name assignment

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Add clarifying comment for server_name fallback logic

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Fix undefined variable reference in log statement

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Move server_name assignment outside try block to ensure it's always available in exception handler

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Clarify comment for server_name fallback logic

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Add server_name fallback logic in OpenAI MCP tool registration service

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Improve variable naming consistency and add server_name fallback in Semantic Kernel service

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Fix inconsistent server_name usage in Semantic Kernel service

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Add server_name fallback logic in configuration service URL construction

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Run ruff formatter to fix formatting issues

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

* Update tests/tooling/test_mcp_server_configuration.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update tests/tooling/test_mcp_server_configuration.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update tests/tooling/test_mcp_server_configuration.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>
Co-authored-by: Johan Broberg <johan@pontemonti.net>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pontemonti pontemonti requested a review from a team as a code owner January 26, 2026 17:33
@pontemonti pontemonti merged commit 4ec6834 into users/johanb/CodeReviewSkill Jan 26, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants