Add support for custom MCP server URLs (#96) #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial plan * Add support for custom MCP server URLs Co-authored-by: pontemonti <[email protected]> * Add comprehensive tests for custom MCP server URL support Co-authored-by: pontemonti <[email protected]> * Remove unnecessary hasattr check in exception handler Co-authored-by: pontemonti <[email protected]> * Simplify custom URL checks by removing redundant strip calls Co-authored-by: pontemonti <[email protected]> * Improve exception handling and clarify test comments Co-authored-by: pontemonti <[email protected]> * Refactor to consistently store URLs in the url field Co-authored-by: pontemonti <[email protected]> * Use 'url' field consistently in both manifest and gateway responses Co-authored-by: pontemonti <[email protected]> * Refactor gateway parsing to match manifest logic and improve variable naming Co-authored-by: pontemonti <[email protected]> * Fix formatting: remove extra blank line in test Co-authored-by: pontemonti <[email protected]> * Rename custom_url to endpoint for better clarity Co-authored-by: pontemonti <[email protected]> * Remove fallback logic and use config.url directly in all tool registration services Co-authored-by: pontemonti <[email protected]> * Remove redundant null check for server_url in Agent Framework service Co-authored-by: pontemonti <[email protected]> * Use 'or' operator for cleaner fallback logic in server_name assignment Co-authored-by: pontemonti <[email protected]> * Add clarifying comment for server_name fallback logic Co-authored-by: pontemonti <[email protected]> * Fix undefined variable reference in log statement Co-authored-by: pontemonti <[email protected]> * Move server_name assignment outside try block to ensure it's always available in exception handler Co-authored-by: pontemonti <[email protected]> * Clarify comment for server_name fallback logic Co-authored-by: pontemonti <[email protected]> * Add server_name fallback logic in OpenAI MCP tool registration service Co-authored-by: pontemonti <[email protected]> * Improve variable naming consistency and add server_name fallback in Semantic Kernel service Co-authored-by: pontemonti <[email protected]> * Fix inconsistent server_name usage in Semantic Kernel service Co-authored-by: pontemonti <[email protected]> * Add server_name fallback logic in configuration service URL construction Co-authored-by: pontemonti <[email protected]> * Run ruff formatter to fix formatting issues Co-authored-by: pontemonti <[email protected]> * Update tests/tooling/test_mcp_server_configuration.py Co-authored-by: Copilot <[email protected]> * Update tests/tooling/test_mcp_server_configuration.py Co-authored-by: Copilot <[email protected]> * Update tests/tooling/test_mcp_server_configuration.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pontemonti <[email protected]> Co-authored-by: Johan Broberg <[email protected]> Co-authored-by: Copilot <[email protected]>
pontemonti
merged commit 4ec6834
into
users/johanb/CodeReviewSkill
6 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial plan
Add support for custom MCP server URLs
Add comprehensive tests for custom MCP server URL support
Remove unnecessary hasattr check in exception handler
Simplify custom URL checks by removing redundant strip calls
Improve exception handling and clarify test comments
Refactor to consistently store URLs in the url field
Use 'url' field consistently in both manifest and gateway responses
Refactor gateway parsing to match manifest logic and improve variable naming
Fix formatting: remove extra blank line in test
Rename custom_url to endpoint for better clarity
Remove fallback logic and use config.url directly in all tool registration services
Remove redundant null check for server_url in Agent Framework service
Use 'or' operator for cleaner fallback logic in server_name assignment
Add clarifying comment for server_name fallback logic
Fix undefined variable reference in log statement
Move server_name assignment outside try block to ensure it's always available in exception handler
Clarify comment for server_name fallback logic
Add server_name fallback logic in OpenAI MCP tool registration service
Improve variable naming consistency and add server_name fallback in Semantic Kernel service
Fix inconsistent server_name usage in Semantic Kernel service
Add server_name fallback logic in configuration service URL construction
Run ruff formatter to fix formatting issues
Update tests/tooling/test_mcp_server_configuration.py
Update tests/tooling/test_mcp_server_configuration.py
Update tests/tooling/test_mcp_server_configuration.py