Fix AttributeError in notification routing when subchannel is None#33
Merged
mrunalhirve128 merged 1 commit intomainfrom Nov 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors code in the agent_notification.py file to make it more concise and improve null safety.
- Consolidates multi-line variable assignments into single-line expressions with inline
.lower()calls - Adds explicit null checking for
ch.sub_channelto prevent potentialAttributeErrorwhen the value isNone
pontemonti
approved these changes
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notification routing logic was throwing AttributeError: 'NoneType' object has no attribute 'lower' when processing notifications where ch.sub_channel was None.
The original code checked if ch exists but didn't verify that ch.sub_channel itself was not None before calling .lower()
The fix ensures .lower() is always called on a string (either the actual value or an empty string), never on None