Use regex for dependency version specifier parsing #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pontemonti <[email protected]>
Copilot
AI
changed the title
[WIP] WIP address feedback on dependency diagram and script changes
Use regex for dependency version specifier parsing
Dec 3, 2025
pontemonti
approved these changes
Dec 3, 2025
pontemonti
added a commit
that referenced
this pull request
Dec 4, 2025
* Add dependency diagram and script to generate dependency diagram. * Change layout of diagram to make it easier to read * Update generate_dependency_diagram.py Co-authored-by: Copilot <[email protected]> * Optimize file I/O by caching pyproject data during first pass (#81) * Initial plan * Optimize file I/O by caching pyproject data during first pass Co-authored-by: pontemonti <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pontemonti <[email protected]> * Use regex for dependency version specifier parsing (#82) * Initial plan * Use regex for parsing dependency version specifiers Co-authored-by: pontemonti <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pontemonti <[email protected]> * Formatting fixes --------- Co-authored-by: Johan Broberg <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: pontemonti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency parsing logic in
generate_dependency_diagram.pyused chainedsplit()calls that failed for dependencies with multiple version specifiers (e.g.,package>=1.0,<2.0).Changes
split('>=')[0].split('==')[0].split('<')[0]with regex-based parsingre.split(r'[><=!~]', dep)[0].strip()to correctly extract package names regardless of version specifier complexity💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.