Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the TOOLS_MODE environment variable and related functionality that supported different tool modes (HardCodedTools, MockMCPServer, MCPPlatform). The changes simplify the codebase by standardizing on the MCP Platform approach, removing conditional logic for development/mock scenarios and hardcoded tool implementations.
Key Changes
- Removed the
ToolsModeenum andget_tools_mode()function from the utility module - Simplified
get_mcp_base_url()to always return the MCP platform URL, removing mock server fallback logic - Streamlined
add_tool_servers_to_agent()to always use Bearer token authentication, removing support for mock authorization and hardcoded tools
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/utility.py | Removed ToolsMode enum, get_tools_mode() function, and conditional logic in get_mcp_base_url() and get_mcp_platform_authentication_scope() |
| libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/init.py | Removed get_tools_mode from exports list |
| libraries/microsoft-agents-a365-tooling-extensions-semantickernel/microsoft_agents_a365/tooling/extensions/semantickernel/services/mcp_tool_registration_service.py | Removed tools mode checking, mock authorization logic, hardcoded tools support, and simplified authentication to always use Bearer token |
...soft_agents_a365/tooling/extensions/semantickernel/services/mcp_tool_registration_service.py
Show resolved
Hide resolved
pontemonti
approved these changes
Dec 4, 2025
tmlsousa
approved these changes
Dec 8, 2025
...soft_agents_a365/tooling/extensions/semantickernel/services/mcp_tool_registration_service.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.