Skip to content

Removing TOOLS_MODE#84

Merged
abdulanu0 merged 1 commit intomainfrom
users/anabdul/remove_tools_mode
Dec 17, 2025
Merged

Removing TOOLS_MODE#84
abdulanu0 merged 1 commit intomainfrom
users/anabdul/remove_tools_mode

Conversation

@abdulanu0
Copy link
Contributor

No description provided.

@abdulanu0 abdulanu0 requested a review from a team as a code owner December 4, 2025 19:37
Copilot AI review requested due to automatic review settings December 4, 2025 19:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the TOOLS_MODE environment variable and related functionality that supported different tool modes (HardCodedTools, MockMCPServer, MCPPlatform). The changes simplify the codebase by standardizing on the MCP Platform approach, removing conditional logic for development/mock scenarios and hardcoded tool implementations.

Key Changes

  • Removed the ToolsMode enum and get_tools_mode() function from the utility module
  • Simplified get_mcp_base_url() to always return the MCP platform URL, removing mock server fallback logic
  • Streamlined add_tool_servers_to_agent() to always use Bearer token authentication, removing support for mock authorization and hardcoded tools

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/utility.py Removed ToolsMode enum, get_tools_mode() function, and conditional logic in get_mcp_base_url() and get_mcp_platform_authentication_scope()
libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/init.py Removed get_tools_mode from exports list
libraries/microsoft-agents-a365-tooling-extensions-semantickernel/microsoft_agents_a365/tooling/extensions/semantickernel/services/mcp_tool_registration_service.py Removed tools mode checking, mock authorization logic, hardcoded tools support, and simplified authentication to always use Bearer token

@abdulanu0 abdulanu0 enabled auto-merge (squash) December 17, 2025 19:16
@abdulanu0 abdulanu0 disabled auto-merge December 17, 2025 19:17
@abdulanu0 abdulanu0 enabled auto-merge (squash) December 17, 2025 19:17
@abdulanu0 abdulanu0 merged commit 802060f into main Dec 17, 2025
14 checks passed
@abdulanu0 abdulanu0 deleted the users/anabdul/remove_tools_mode branch December 17, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants