Skip to content

[O11y] Adds channel data to inference and tool scopes.#89

Merged
juliomenendez merged 4 commits intomainfrom
juliome/o11y-pass-channel-data-all-scopes
Dec 11, 2025
Merged

[O11y] Adds channel data to inference and tool scopes.#89
juliomenendez merged 4 commits intomainfrom
juliome/o11y-pass-channel-data-all-scopes

Conversation

@juliomenendez
Copy link
Contributor

@juliomenendez juliomenendez commented Dec 10, 2025

Also fixes assertions that were never running to validate data within the generated span.

Copilot AI review requested due to automatic review settings December 10, 2025 17:48
@juliomenendez juliomenendez requested a review from a team as a code owner December 10, 2025 17:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds channel data (source metadata) to inference and tool execution observability scopes. The changes enable tracking of execution source information (channel name and link/description) through OpenTelemetry span attributes, providing better context for agent operations.

Key Changes:

  • Extended InferenceScope and ExecuteToolScope to capture and record source metadata from requests
  • Updated copyright headers in test files to follow the standard Microsoft format
  • Added comprehensive tests to verify source metadata is correctly set on spans

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
tests/observability/core/test_inference_scope.py Updated copyright header and added test for source metadata on inference spans
tests/observability/core/test_execute_tool_scope.py Added test for source metadata on tool execution spans
libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/inference_scope.py Added source metadata capture logic to set channel attributes on spans
libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/execute_tool_scope.py Added source metadata capture logic and request parameter support

Copilot AI review requested due to automatic review settings December 10, 2025 19:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

@juliomenendez juliomenendez enabled auto-merge (squash) December 10, 2025 20:34
@fpfp100
Copy link

fpfp100 commented Dec 10, 2025

Any reason conversation Id is not included in this PR?

@juliomenendez juliomenendez merged commit 3d097c4 into main Dec 11, 2025
8 checks passed
@juliomenendez juliomenendez deleted the juliome/o11y-pass-channel-data-all-scopes branch December 11, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants