Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 5, 2026

Addresses review feedback on PR #97 regarding a missing copyright header and incorrect filename in the exporters module.

Changes

  • Renamed file: __init__py__init__.py (added missing .py extension)
  • Added copyright header: Prepended required Microsoft copyright notice to file

The file was incorrectly named without the dot separator, breaking Python module conventions. Now properly includes:

# Copyright (c) Microsoft Corporation.
# Licensed under the MIT License.

# Agent365Exporter is not exported intentionally.
# It should only be used internally by the observability core module.
__all__ = ["Agent365ExporterOptions"]

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback from review on previous pull request Fix __init__.py filename and add copyright header in exporters module Jan 5, 2026
@nikhilNava nikhilNava marked this pull request as ready for review January 5, 2026 13:25
@nikhilNava nikhilNava requested a review from a team as a code owner January 5, 2026 13:25
@nikhilNava nikhilNava merged commit 88046cd into nikhilc/fixInitialization Jan 5, 2026
1 check passed
@nikhilNava nikhilNava deleted the copilot/sub-pr-97-again branch January 5, 2026 13:25
Copilot AI requested a review from nikhilNava January 5, 2026 13:25
nikhilNava added a commit that referenced this pull request Jan 6, 2026
* ensure exporter is added if reusing the tracer provider

* Mak te A365exporter internal and final so its not instantiated outside the core sdk

* add tests

* Fix __init__.py filename and add copyright header in exporters module (#99)

* Initial plan

* Fix filename and add copyright header to exporters __init__.py

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

* fix PR comments and tests

* fix PR comments

---------

Co-authored-by: Nikhil Chitlur Navakiran (from Dev Box) <nikhilc@microsoft.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants