Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 4, 2025

This PR fixes the CI failures in #4264 caused by dependency version conflicts when upgrading OpenTelemetry instrumentation from 2.16.0-alpha to 2.17.0-alpha.

Problem

The original dependabot PR #4264 updated only the otelInstrumentationAlphaVersion but missed updating the corresponding OpenTelemetry SDK version. This created a dependency conflict because:

  • OpenTelemetry instrumentation 2.17.0-alpha requires OpenTelemetry SDK 1.51.0
  • The project was still pinned to OpenTelemetry SDK 1.50.0
  • This caused Gradle dependency resolution to fail with version constraint conflicts

Solution

Updated all OpenTelemetry dependency versions to maintain consistency:

// Before
val otelSdkVersion = "1.50.0"
val otelInstrumentationAlphaVersion = "2.17.0-alpha"
val otelInstrumentationVersion = "2.16.0"

// After  
val otelSdkVersion = "1.51.0"
val otelInstrumentationAlphaVersion = "2.17.0-alpha"
val otelInstrumentationVersion = "2.17.0"

Breaking Changes Assessment

OpenTelemetry 2.17.0 introduced breaking changes to Tomcat metric names (e.g., http.server.tomcat.errorCounttomcat.error.count), but analysis of the codebase confirmed that ApplicationInsights-Java doesn't reference these deprecated metric names, so no code changes were needed.

Validation

  • ✅ Clean build completes successfully (1313 tasks)
  • ✅ All unit tests pass (189 tasks)
  • ✅ JMX metric smoke tests pass
  • ✅ No references to deprecated Tomcat metrics found in codebase
  • ✅ Dependency conflicts resolved

Fixes #4267.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 123.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -Dorg.gradle.internal.worker.tmpdir=/home/REDACTED/work/ApplicationInsights-Java/ApplicationInsights-Java/agent/agent-tooling/build/tmp/test/work @/home/REDACTED/.gradle/.tmp/gradle-worker-classpath2198103400187408890txt -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -ea worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Test Executor 6' (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@Copilot Copilot AI assigned Copilot and trask Jul 4, 2025
@Copilot Copilot AI changed the title [WIP] Fix CI failures in https://github.com/microsoft/ApplicationInsights-Java/pull/4264 Fix OpenTelemetry 2.17.0-alpha dependency version conflicts Jul 4, 2025
@Copilot Copilot AI requested a review from trask July 4, 2025 19:11
Copilot finished work on behalf of trask July 4, 2025 19:11
@trask
Copy link
Member

trask commented Jul 7, 2025

@copilot rebase

Copy link
Contributor Author

Copilot AI commented Jul 7, 2025

@copilot rebase

I cannot perform a rebase operation directly as I don't have the ability to use git rebase with force push. The rebase would require:

  1. Fetching the latest changes from the base branch
  2. Rebasing my commits on top of the latest base
  3. Potentially resolving conflicts
  4. Force pushing the rebased branch

Since I can only use the report_progress tool for git operations, I cannot perform these operations. You'll need to either:

  • Perform the rebase manually, or
  • Let me know if you'd like me to recreate the changes on a fresh branch instead

Copilot finished work on behalf of trask July 7, 2025 15:38
@trask trask force-pushed the copilot/fix-4267 branch 2 times, most recently from 79f2710 to 8e7085b Compare July 7, 2025 19:30
@trask trask force-pushed the copilot/fix-4267 branch from 3fd3a4c to 6027d96 Compare July 7, 2025 20:48
@trask trask closed this Jul 7, 2025
@trask trask deleted the copilot/fix-4267 branch July 11, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI failures in https://github.com/microsoft/ApplicationInsights-Java/pull/4264
2 participants