Remove old API migrations #4168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4079 Remove deprecated migration steps from the `migrate_database` function in `api_app/api/routes/migrations.py`. * **Migration Steps Removal** - Remove multiple deprecated migration steps from the `migrate_database` function. - Update the `migrate_database` function to only include necessary migration steps. * **Version Update** - Update the version in `api_app/_version.py` from "0.19.3" to "0.20.0". * **Test Updates** - Remove tests related to deprecated migration steps in `api_app/tests_ma/test_api/test_routes/test_migrations.py`. - Update tests to only include necessary migration steps. * **File Deletions** - Delete `api_app/db/migrations/airlock.py`. - Delete `api_app/db/migrations/resources.py`. - Delete `api_app/db/migrations/shared_services.py`. - Delete `api_app/db/migrations/workspaces.py`. - Delete `api_app/tests_ma/test_db/test_migrations/test_workspace_migration.py`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4079?shareId=XXXX-XXXX-XXXX-XXXX).
|
@tim-allen-ck hopefully this is a start, not tested etc, but please feel free to take this and iterate. |
Unit Test Results607 tests 605 ✅ 7s ⏱️ For more details on these failures, see this check. Results for commit 5afb401. ♻️ This comment has been updated with latest results. |
|
/test |
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- api_app/db/migrations/airlock.py: Evaluated as low risk
- api_app/db/migrations/resources.py: Evaluated as low risk
- api_app/db/migrations/shared_services.py: Evaluated as low risk
- api_app/db/migrations/workspaces.py: Evaluated as low risk
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13318093522 (with refid (in response to this comment from @marrobi) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4079
Remove deprecated migration steps from the
migrate_databasefunction inapi_app/api/routes/migrations.py.migrate_databasefunction.migrate_databasefunction to only include necessary migration steps.api_app/_version.pyfrom "0.19.3" to "0.20.0".api_app/tests_ma/test_api/test_routes/test_migrations.py.api_app/db/migrations/airlock.py.api_app/db/migrations/resources.py.api_app/db/migrations/shared_services.py.api_app/db/migrations/workspaces.py.api_app/tests_ma/test_db/test_migrations/test_workspace_migration.py.For more details, open the Copilot Workspace session.