-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexus Linux machine uses SSH keys #4366
base: main
Are you sure you want to change the base?
Conversation
Fixes #4359 Update Sonatype Nexus VM to require SSH key-based authentication. * Remove password-based authentication and related resources from `templates/shared_services/sonatype-nexus-vm/terraform/vm.tf`. * Add resources to generate and store SSH keys in Key Vault. * Update the `connection` block to use the SSH private key for authentication. * Update `docs/tre-templates/shared-services/nexus.md` to reflect the change to SSH key-based authentication and provide instructions on how to retrieve the SSH private key from Key Vault. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4359?shareId=XXXX-XXXX-XXXX-XXXX).
@jonnyry ran his through copilot, fancy testing and fixing up? |
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 677fb05. |
there's a few issues with it that I can see at first glance -
I've got a fix for this issue locally that uses a bash script to keep the SSH private key out of TF state. Happy to PR back if you like. |
Hmm, I'd like to avoid even more bash script to be honest. How about an Ephemeral resource - https://developer.hashicorp.com/terraform/language/resources/ephemeral |
Currently they can only read existing secrets/certs in azurerm provider: |
Fixes #4359
Update Sonatype Nexus VM to require SSH key-based authentication.
templates/shared_services/sonatype-nexus-vm/terraform/vm.tf
.connection
block to use the SSH private key for authentication.docs/tre-templates/shared-services/nexus.md
to reflect the change to SSH key-based authentication and provide instructions on how to retrieve the SSH private key from Key Vault.For more details, open the Copilot Workspace session.