Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set stairlockp Airlock Processor storage account firewall to "Enabled from selected virtual networks and IP addresses" #4388

Closed

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Feb 21, 2025

Resolves #4386

Requires extended e2e

Copy link

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 7b18c44.

@jonnyry jonnyry requested a review from marrobi February 21, 2025 09:32
@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 21, 2025

/help

Copy link

🤖 pr-bot 🤖

Hello!

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @jonnyry)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 21, 2025

/test-extended

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nothing breaks, LGTM :)

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13454082718 (with refid b15e4e71)

(in response to this comment from @jonnyry)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 21, 2025

Hmm e2e tests failing on:

Error: User not found with object ID: "166c1944-f777-4347-9819-0ebc140447c9" │ │ with data.azuread_user.user, │ on data.tf line 53, in data "azuread_user" "user": │ 53: object_id = var.owner_id │

this line:

data "azuread_user" "user" {
  object_id = var.owner_id
}

owner_id was added in #4333.

Trying to figure out where this is coming from @marrobi can you help?

@jonnyry jonnyry closed this Feb 24, 2025
@jonnyry jonnyry force-pushed the jr/upstream-main/153-airlockp-sa-firewall branch from 7b18c44 to 942162d Compare February 24, 2025 09:36
@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 24, 2025

Closed due to repo re-organisation at the remote end. Will create new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airlock processor storage account - network restrictions?
3 participants