Repository navigation
Replace constant configuration with code constants - #932
Draft
Sun Haoran (haoranpb) wants to merge 3 commits into
Draft
Sun Haoran (haoranpb) wants to merge 3 commits into
Sun Haoran (haoranpb) wants to merge 3 commits into
Conversation
Sun Haoran (haoranpb)
force-pushed
the
app/stack-01-config-constants
branch
from
October 6, 2026 11:24
f120583 to
ba8cf63
Compare
Sun Haoran (haoranpb)
changed the base branch from
core/stack-09-copilot-session
to
core/stack-08-copilot-cli
October 6, 2026 11:25
This was referenced Oct 6, 2026
Sun Haoran (haoranpb)
added this pull request to stack #960
October 8, 2026 12:17
Contributor
Code Coverage OverviewLanguages: Python Python / code-coverage/pytestThe overall line coverage in commit 678c40b in the Show a line coverage summary of the most impacted files.
Updated |
Config held values that never vary per run; only deployment settings remain (repository paths, judge models, GitHub environment flags). - File-name conventions become constants in the module that owns them: INSTANCE_ID_PATTERN and PROBLEM_STATEMENT_README (dataset entries), RESULT_FILE_SUFFIX (results), INSTRUCTION_SOURCE_FILE and PROBLEM_STATEMENT_DEST_DIR (instruction operations), PLUGIN_MANIFEST (plugins). The unused trajectory pattern is dropped, and patch separation defaults to the "test"/"tests" identifiers. - Timeouts become parameter defaults with the same values: agent runs (60 min), bcal (25 min), filepath identification and data-query execution (15 min). - Package-relative paths move to bcbench.paths (AGENT_SHARE_DIR, SHARED_CONFIG_FILE) instead of being derived from the git root. Eight runtime modules no longer read get_config() at import time. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sun Haoran (haoranpb)
force-pushed
the
app/stack-01-config-constants
branch
from
October 8, 2026 13:13
e285654 to
6a12884
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal 2 (app boundaries), step 1, stacked directly on #930 (#931 is superseded). Design reference: #929, used as exploration.
Most of what runtime modules read from
get_config()is constant, not configuration. This PR turns it into code, so only real deployment settings stay inConfig(repository paths, judge models, GitHub environment flags):bcbench.paths.Eight runtime modules no longer read configuration at import. No behaviour change.