Skip to content

dataset(code-review): add reaction gold answers from BCApps PR 12418-neg-pr12418-20261020 - #976

Draft
Wenjie Fan (gggdttt) wants to merge 1 commit into
mainfrom
self-improvement/bcapps-12418-neg-pr12418-20261020-synthetic-eval
Draft

Wenjie Fan (gggdttt) wants to merge 1 commit into
mainfrom
self-improvement/bcapps-12418-neg-pr12418-20261020-synthetic-eval

Conversation

@gggdttt

@gggdttt Wenjie Fan (gggdttt) commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds code-review gold answers from explicit BCApps PR feedback.

Negative guards use exact source-file patches at immutable reviewed revisions, not invented synthetic code. Their targets are omitted from both expected and ignored comments; new negative-only entries have no expected findings.
Existing eligible gold answers are reused without changing their payloads.

Accepted findings

Rejected findings

Knowledge dependency

Validation

See the gate-owned offline evaluation section below.

Generated by the BC-ALAgentsInternal self-improvement workflow.

Offline evaluation: regression

Candidate correctness failed: unexpected or missed findings remain. Existing ignored gold comments retain their neutral scoring semantics.

Preparation attempt 1: validated.

Selection: new. New: synthetic__breaking-intentional-public-widen-01. Reused (complete payloads): ``.

  • synthetic__breaking-intentional-public-widen-01 / false_positive_guard / #12375 Make OpenEDocument method public BCApps#12418 (comment): The reviewer bot flagged widening OpenEDocument from internal to public as a medium-severity breaking change and received a THUMBS_DOWN plus an explicit maintainer rejection ("It is completely opposite to the request!"), because the PR's whole purpose (per its title, referencing issue #12375) was to make OpenEDocument public. The synthetic entry reuses the exact pipeline-validated source snapshot patch/repo/base_commit for this file and line, with expected_comments=[] so an agent must not raise the same internal-vs-public finding here. Limitation: this guard only covers the case where widening access is the PR's stated intentional goal; it does not generalize to unrelated or incidental access-modifier widenings, which remain coverable by other entries such as synthetic__breaking-access-modifier-01 and synthetic__breaking-scope-creep-unrelated-api-01.
    Coverage references and outcome shapes are validated mechanically. Semantic equivalence, severity calibration and recommendation quality are NOT proved by these checks or a matching F1.

Common engine code: ecf8e31759d6ddd6d78e3a0b7836b40134368009; dataset SHA256: 035CCF13286222982DEA553D2DDA0CFAEAC3F8F556401169DD1567236A88CDD2.
Model: gpt-5.6-luna; judge: gpt-5.3-codex. Exact D: synthetic__breaking-intentional-public-widen-01.
Dataset base: 7c98b750c200d88ed0a81daaea5e71184a3af01b; candidate: d8543474d1739f5fda9c9ea13e79fbe5b2fd8931.

Arm Evaluation commit Engine pin Knowledge pin
baseline c84b1659b05517b341517c40a9d2d6eb08d63e6d edd46ef34e9b38d7cc2fc3e1c1c806ff8e476ab6 f820aa1e8515a6483b828d9a5b1c55112461b4d9
candidate 0f60d3c1a8167c7cbe5b6740a740ec83a3bc96e6 7a0d53aa129f945696f5bd9841d7e4ac1256a05d 31b002fb20d3e0b1437ae2a6dd0217f9e7fd8cd9

Baseline

Run: https://github.com/microsoft/BC-Bench/actions/runs/39415090999; conclusion: success; wall clock: 8 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.

Entry Expected Generated Missed Unexpected F1 AI credits Agent seconds
synthetic__breaking-intentional-public-widen-01 0 1 0 1 0 unavailable 279.9232094

Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.

Aggregate metric Value
total 1
expected_comment_count 0
generated_comment_count 1
matched_comment_count 0
missed_comment_count 0
incorrect_comment_count 1
precision 0
recall 1
f1 0

Candidate

Run: https://github.com/microsoft/BC-Bench/actions/runs/39416101487; conclusion: success; wall clock: 6.3 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.

Entry Expected Generated Missed Unexpected F1 AI credits Agent seconds
synthetic__breaking-intentional-public-widen-01 0 1 0 1 0 unavailable 248.8782851

Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.

Aggregate metric Value
total 1
expected_comment_count 0
generated_comment_count 1
matched_comment_count 0
missed_comment_count 0
incorrect_comment_count 1
precision 0
recall 1
f1 0

Missing telemetry is unavailable, not zero. Evaluation-only metrics exclude candidate generation and are not the full-cycle cost.
Human review must verify source-patch fidelity, gold correctness, and target attribution. No automatic merge or branch-protection claim is made.

Cycle usage and elapsed time (running, as of 2026-10-20T11:42:23.3976843+00:00)

Orchestrator work: 1174.62 seconds. This is not the completed GitHub workflow duration.

Stage / attempt Status / outcome Elapsed seconds
preflight / 1 completed / 7.584
quality_preparation / 1 completed / 122.306
gold_preparation / 1 completed / selected_new 125.345
evaluation_preparation / 1 completed / 27.608
baseline / 1 completed / success 507.446
candidate / 1 completed / success 383.507
gate_verdict / 1 completed / regression 0.013
publication / 1 running / 0.028
receipts / 1 not_started / unavailable
quality_validation / 1 completed / 5.005
gold_attempt / 1 completed / validated 110.608
Measure Known subtotal Whole-cycle total Known / required components
ai_credit: aiCredits 59.83954 unavailable 2 / 6
premium_request: premiumRequests 46 unavailable 2 / 6
token: inputTokens 12851843 unavailable 4 / 6
token: outputTokens 120042 unavailable 4 / 6
token: totalTokens 12971885 unavailable 4 / 6

Subtotals are CLI/Bench-reported usage, not invoices. Missing values are not zero. Emitted-span coverage does not prove complete child/background billing; judge usage is not exported. Premium requests are not AI credits or currency.
Nested stage, agent and API durations are not added into cycle wall clock. Root queue/setup, telemetry export, artifact upload and later dashboard publication are excluded.
PR evidence is an as-of snapshot before publication completes. Final-for-orchestrator metrics are emitted to self-improvement-cycle.json in the root self-improvement-feedback artifact and its Actions summary when persistence succeeds; a running checkpoint is not final evidence.
Root run: https://github.com/microsoft/BC-ALAgentsInternal/actions/runs/39414475364/attempts/1

@github-code-quality

Copy link
Copy Markdown
Contributor

Code coverage overview

Languages: Python

Python / code-coverage/pytest

main 7c98b75 self-improvement/bca... d854347 +/-
88% 88% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant