- 
        Couldn't load subscription status. 
- Fork 369
Update OnPremOAuthFunctions.ps1 #2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ACS is no longer the default AuthServer - Updated to check for EvoSts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the OnPremOAuthFunctions.ps1 to replace deprecated ACS (Access Control Service) authentication with EvoSts authentication server configuration. This change addresses the deprecation of ACS as the default AuthServer.
- Replaced ACS filter pattern with EvoSts pattern in AuthServer retrieval
- Updated validation patterns for IssuerIdentifier, TokenIssuingEndpoint, and AuthMetadataUrl to match EvoSts endpoints
- Modified error messages to reflect correct EvoSts endpoint formats
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @microsoft-github-policy-service agree | 
Co-authored-by: Copilot <[email protected]>
| @MarcoLFrancisco to review | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, thank you.
| /azp run | 
| Azure Pipelines successfully started running 1 pipeline(s). | 
| /azp run | 
| Azure Pipelines successfully started running 1 pipeline(s). | 
| @Ghost0s please follow our contributing guides to get your PR to properly work and pass the build pipeline process: https://github.com/microsoft/CSS-Exchange/blob/main/CONTRIBUTING.md Then if you know how, please rebase your branch so there is only 1 commit on the branch you are trying to merge into ours. | 
| @MedElhamm0uti as I provided before, you need to follow the contributing guide to get past the build pipeline. Otherwise, this PR will not merge. https://github.com/microsoft/CSS-Exchange/blob/main/CONTRIBUTING.md | 

Issue:
ACS is no longer the default AuthServer and has been deprecated
Reason:
ACS is no longer the default AuthServer and has been deprecated
Fix:
Updated to check for EvoSts
Validation:
Provide if applicable