Skip to content

Conversation

@MedElhamm0uti
Copy link

Issue:
ACS is no longer the default AuthServer and has been deprecated

Reason:
ACS is no longer the default AuthServer and has been deprecated

Fix:
Updated to check for EvoSts

Validation:
Provide if applicable

ACS is no longer the default AuthServer - Updated to check for EvoSts
@MedElhamm0uti MedElhamm0uti requested a review from a team as a code owner September 22, 2025 13:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the OnPremOAuthFunctions.ps1 to replace deprecated ACS (Access Control Service) authentication with EvoSts authentication server configuration. This change addresses the deprecation of ACS as the default AuthServer.

  • Replaced ACS filter pattern with EvoSts pattern in AuthServer retrieval
  • Updated validation patterns for IssuerIdentifier, TokenIssuingEndpoint, and AuthMetadataUrl to match EvoSts endpoints
  • Modified error messages to reflect correct EvoSts endpoint formats

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MedElhamm0uti
Copy link
Author

@microsoft-github-policy-service agree

@dpaulson45
Copy link
Member

@MarcoLFrancisco to review

Copy link
Contributor

@MarcoLFrancisco MarcoLFrancisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thank you.

@dpaulson45
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dpaulson45
Copy link
Member

@Ghost0s Please address the spelling that failed here:

image

Use camelCasing or PascalCase

@dpaulson45
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dpaulson45
Copy link
Member

@Ghost0s please follow our contributing guides to get your PR to properly work and pass the build pipeline process:

https://github.com/microsoft/CSS-Exchange/blob/main/CONTRIBUTING.md

Then if you know how, please rebase your branch so there is only 1 commit on the branch you are trying to merge into ours.

@dpaulson45
Copy link
Member

@MedElhamm0uti as I provided before, you need to follow the contributing guide to get past the build pipeline. Otherwise, this PR will not merge.

https://github.com/microsoft/CSS-Exchange/blob/main/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants