Skip to content

fix: Waf changes#33

Merged
Roopan-Microsoft merged 23 commits intodevfrom
waf-changes
Oct 20, 2025
Merged

fix: Waf changes#33
Roopan-Microsoft merged 23 commits intodevfrom
waf-changes

Conversation

@Ravikirana-Microsoft
Copy link
Contributor

Purpose

This pull request introduces significant improvements to the Azure infrastructure codebase, focusing on enhanced network configuration, parameterization, and support for security and scalability. The most important changes include the addition of a comprehensive virtual network module with detailed subnet and NSG definitions, expanded deployment parameters for both main and WAF templates, and improved support for secure VM access.

Infrastructure and Networking Enhancements:

  • Added a new virtualNetwork.bicep module that defines multiple subnets (containers, backend, Azure Bastion, jumpbox), each with tailored Network Security Group (NSG) rules, delegation, and policies. This includes outputs for subnet and NSG resource IDs, as well as custom type definitions for subnet and NSG configurations.

Parameterization and Deployment Improvements:

  • Updated main.parameters.json to include new parameters for monitoring, private networking, scalability, and VM admin credentials, enabling more flexible and secure deployments.
  • Added a new main.waf.parameters.json template with a full set of deployment parameters, including AI model configuration, telemetry, monitoring, networking, scalability, and VM admin credentials, supporting WAF-specific deployments.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Ravikirana-Microsoft and others added 12 commits October 8, 2025 15:34
…rtual network configuration

- Deleted obsolete Bicep files: network.bicep, bastionHost.bicep, jumpbox.bicep, main.bicep, and virtualNetwork.bicep.
- Introduced a new virtualNetwork.bicep file with updated subnet configurations and security rules.
- Streamlined the creation of Azure Bastion and Jumpbox resources within the new structure.
- Enhanced documentation and best practices for subnet sizing and security group configurations.
@Ravikirana-Microsoft Ravikirana-Microsoft changed the title Waf changes fix: Waf changes Oct 17, 2025
@Roopan-Microsoft Roopan-Microsoft marked this pull request as ready for review October 20, 2025 07:30
@Roopan-Microsoft Roopan-Microsoft merged commit a64fd4b into dev Oct 20, 2025
6 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Roopan-Microsoft Roopan-Microsoft deleted the waf-changes branch January 9, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants