Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
28b3fe1
fix: Update test execution logic for Azure environment use cases and …
Vamshi-Microsoft Jan 19, 2026
fa699fb
fix: Update workflow names for Linux and Windows deployment to includ…
Vamshi-Microsoft Jan 19, 2026
55a817d
Added back e2e Job condition
Vamshi-Microsoft Jan 19, 2026
d9c4c16
Changed tag to latest_waf
Vamshi-Microsoft Jan 19, 2026
edad86b
added sample data processing step
Vamshi-Microsoft Jan 20, 2026
bab1d03
Added ODBC Driver installation step and enhance user/service principa…
Vamshi-Microsoft Jan 20, 2026
8632250
Update ODBC Driver installation step
Vamshi-Microsoft Jan 20, 2026
ffed96d
Add usecase parameter to paramter files
Vamshi-Microsoft Jan 20, 2026
69d6a17
Enhance SQL role assignment script to support service principal
Vamshi-Microsoft Jan 20, 2026
5f7dfcf
Refine help text for roles-json argument in SQL roles assignment script
Vamshi-Microsoft Jan 21, 2026
26562e8
Updated user creation logic in SQL roles assignment script to simplif…
Vamshi-Microsoft Jan 21, 2026
526e8db
Modified Post Deployment Script to Support both User and ServicePrinc…
Vamshi-Microsoft Jan 21, 2026
ced3d90
Minor fix
Vamshi-Microsoft Jan 21, 2026
9417889
Add wait logic for role assignment propagation
Vamshi-Microsoft Jan 21, 2026
0038a3f
Enabled send-notification job
Vamshi-Microsoft Jan 21, 2026
67812f7
Update ODBC Driver installation to use PowerShell for Windows
Vamshi-Microsoft Jan 21, 2026
87ab280
Add retry logic for uploading files to storage account
Vamshi-Microsoft Jan 21, 2026
0269657
Set PYTHONIOENCODING to utf-8 for process_sample_data steps
Vamshi-Microsoft Jan 21, 2026
855736c
Resolved copilet suggestions
Vamshi-Microsoft Jan 22, 2026
428c685
Resolved Copilet comments-2
Vamshi-Microsoft Jan 23, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-linux.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Deploy-Test-Cleanup Linux
name: Deploy-Test-Cleanup (v2) Linux
on:
pull_request:
branches:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-orchestrator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
secrets: inherit

e2e-test:
if: false # E2E testing disabled
if: "!cancelled() && ((needs.deploy.result == 'success' && needs.deploy.outputs.WEB_APP_URL != '') || (inputs.existing_webapp_url != '' && inputs.existing_webapp_url != null)) && (inputs.trigger_type != 'workflow_dispatch' || (inputs.run_e2e_tests && inputs.run_e2e_tests != 'None'))"
needs: [docker-build, deploy]
uses: ./.github/workflows/job-test-automation.yml
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-windows.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Deploy-Test-Cleanup Windows
name: Deploy-Test-Cleanup (v2) Windows
on:
# push:
# branches:
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/job-azure-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -457,21 +457,23 @@ jobs:
echo "Current branch: $BRANCH_NAME"

if [[ "$BRANCH_NAME" == "main" ]]; then
IMAGE_TAG="latest"
echo "Using main branch - image tag: latest"
IMAGE_TAG="latest_waf"
echo "Using main branch - image tag: latest_waf"
elif [[ "$BRANCH_NAME" == "dev" ]]; then
IMAGE_TAG="dev"
echo "Using dev branch - image tag: dev"
elif [[ "$BRANCH_NAME" == "demo" ]]; then
IMAGE_TAG="demo"
echo "Using demo branch - image tag: demo"
elif [[ "$BRANCH_NAME" == "hotfix" ]]; then
BASE_TAG="hotfix"
IMAGE_TAG="hotfix"
echo "Using hotfix branch - image tag: hotfix"
elif [[ "$BRANCH_NAME" == "dependabotchanges" ]]; then
BASE_TAG="dependabotchanges"
IMAGE_TAG="dependabotchanges"
echo "Using dependabotchanges branch - image tag: dependabotchanges"
else
IMAGE_TAG="latest"
echo "Using default for branch '$BRANCH_NAME' - image tag: latest"
IMAGE_TAG="latest_waf"
echo "Using default for branch '$BRANCH_NAME' - image tag: latest_waf"
Comment on lines 459 to +476
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image tag naming has changed from "latest" to "latest_waf" for main and default branches. This is a breaking change if there are existing deployments or scripts that rely on the "latest" tag. Ensure that all deployment documentation, external scripts, and CI/CD pipelines that reference the "latest" tag are updated to use "latest_waf" instead.

Copilot uses AI. Check for mistakes.
fi

echo "Using existing Docker image tag: $IMAGE_TAG"
Expand Down Expand Up @@ -509,9 +511,7 @@ jobs:
echo "" >> $GITHUB_STEP_SUMMARY
echo "| Configuration | Value |" >> $GITHUB_STEP_SUMMARY
echo "|---------------|-------|" >> $GITHUB_STEP_SUMMARY
echo "| **Trigger Type** | \`${{ github.event_name }}\` |" >> $GITHUB_STEP_SUMMARY
echo "| **Branch** | \`${{ env.BRANCH_NAME }}\` |" >> $GITHUB_STEP_SUMMARY
echo "| **Runner OS** | \`$INPUT_RUNNER_OS\` |" >> $GITHUB_STEP_SUMMARY
echo "| **WAF Enabled** | $WAF_ENABLED_DISPLAY |" >> $GITHUB_STEP_SUMMARY
echo "| **EXP Enabled** | $EXP_DISPLAY |" >> $GITHUB_STEP_SUMMARY
echo "| **Run E2E Tests** | \`${{ env.RUN_E2E_TESTS }}\` |" >> $GITHUB_STEP_SUMMARY
Expand Down
58 changes: 44 additions & 14 deletions .github/workflows/job-deploy-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ jobs:
if [[ -n "$AZURE_EXISTING_AI_PROJECT_RESOURCE_ID" ]]; then
EXP_AI_PROJECT_ID="$AZURE_EXISTING_AI_PROJECT_RESOURCE_ID"
else
EXP_AI_PROJECT_ID="${{ secrets.AZURE_ENV_FOUNDRY_PROJECT_ID }}"
EXP_AI_PROJECT_ID="${{ secrets.AZURE_EXISTING_AI_PROJECT_RESOURCE_ID }}"
fi

echo "AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID: $EXP_LOG_ANALYTICS_ID"
Expand All @@ -297,24 +297,54 @@ jobs:
azd up --no-prompt

echo "✅ Deployment succeeded."
echo "$DEPLOY_OUTPUT"

echo "Extracting deployment outputs..."
DEPLOY_OUTPUT=$(azd env get-values --output json)
echo "Deployment output: $DEPLOY_OUTPUT"

if [[ -z "$DEPLOY_OUTPUT" ]]; then
echo "Error: Deployment output is empty. Please check the deployment logs."
exit 1
API_APP_URL=$(azd env get-value API_APP_URL)
echo "API_APP_URL=${API_APP_URL}" >> $GITHUB_ENV
echo "API_APP_URL=${API_APP_URL}" >> $GITHUB_OUTPUT

WEB_APP_URL=$(azd env get-value WEB_APP_URL)
echo "WEB_APP_URL=${WEB_APP_URL}" >> $GITHUB_ENV
echo "WEB_APP_URL=${WEB_APP_URL}" >> $GITHUB_OUTPUT

- name: Install ODBC Driver 18 for SQL Server
shell: bash
run: |
if ! [[ "18.04 20.04 22.04 24.04 24.10" == *"$(grep VERSION_ID /etc/os-release | cut -d '"' -f 2)"* ]];
then
echo "Ubuntu $(grep VERSION_ID /etc/os-release | cut -d '"' -f 2) is not currently supported.";
exit 1;
fi

# Download the package to configure the Microsoft repo
curl -fsSL -O https://packages.microsoft.com/config/ubuntu/$(grep VERSION_ID /etc/os-release | cut -d '"' -f 2)/packages-microsoft-prod.deb || { echo "Failed to download Microsoft packages config"; exit 1; }
Comment on lines +313 to +320
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ubuntu version check uses string matching with spaces between version numbers. This approach works but could be fragile. If a version string contains extra whitespace or doesn't match exactly, it will fail. Consider using a more robust version comparison approach, such as regex matching or explicit version checks (e.g., VERSION_ID in ("18.04" "20.04" "22.04" "24.04" "24.10")).

Suggested change
if ! [[ "18.04 20.04 22.04 24.04 24.10" == *"$(grep VERSION_ID /etc/os-release | cut -d '"' -f 2)"* ]];
then
echo "Ubuntu $(grep VERSION_ID /etc/os-release | cut -d '"' -f 2) is not currently supported.";
exit 1;
fi
# Download the package to configure the Microsoft repo
curl -fsSL -O https://packages.microsoft.com/config/ubuntu/$(grep VERSION_ID /etc/os-release | cut -d '"' -f 2)/packages-microsoft-prod.deb || { echo "Failed to download Microsoft packages config"; exit 1; }
UBUNTU_VERSION=$(grep '^VERSION_ID=' /etc/os-release | cut -d '"' -f 2)
case "$UBUNTU_VERSION" in
18.04|20.04|22.04|24.04|24.10)
# Supported versions
;;
*)
echo "Ubuntu $UBUNTU_VERSION is not currently supported.";
exit 1;
;;
esac
# Download the package to configure the Microsoft repo
curl -fsSL -O https://packages.microsoft.com/config/ubuntu/${UBUNTU_VERSION}/packages-microsoft-prod.deb || { echo "Failed to download Microsoft packages config"; exit 1; }

Copilot uses AI. Check for mistakes.
# Install the package
sudo dpkg -i packages-microsoft-prod.deb
# Delete the file
rm packages-microsoft-prod.deb

# Install the driver
sudo apt-get update
sudo ACCEPT_EULA=Y apt-get install -y msodbcsql18
echo "✅ ODBC Driver 18 for SQL Server installed successfully."

API_APP_URL="$(echo "$DEPLOY_OUTPUT" | jq -r '.API_APP_URL // empty')"
echo "API_APP_URL=$API_APP_URL" >> $GITHUB_ENV
echo "API_APP_URL=$API_APP_URL" >> $GITHUB_OUTPUT
- name: Process Sample Data
id: process_sample_data
continue-on-error: true
shell: bash
run: |
echo "Running process_sample_data.sh..."
bash ./infra/scripts/process_sample_data.sh
echo "✅ Sample data processing completed successfully."

WEB_APP_URL="$(echo "$DEPLOY_OUTPUT" | jq -r '.WEB_APP_URL // empty')"
echo "WEB_APP_URL=$WEB_APP_URL" >> $GITHUB_ENV
echo "WEB_APP_URL=$WEB_APP_URL" >> $GITHUB_OUTPUT
- name: Retry Process Sample Data
if: steps.process_sample_data.outcome == 'failure'
shell: bash
run: |
echo "⚠️ First attempt failed. Retrying process_sample_data.sh..."
sleep 20
bash ./infra/scripts/process_sample_data.sh
echo "✅ Sample data processing completed successfully on retry."

- name: Generate Deployment Summary
if: always()
Expand Down
75 changes: 65 additions & 10 deletions .github/workflows/job-deploy-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ jobs:
if ($env:INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID -ne "") {
$EXP_AI_PROJECT_ID = $env:INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID
} else {
$EXP_AI_PROJECT_ID = "${{ secrets.AZURE_ENV_FOUNDRY_PROJECT_ID }}"
$EXP_AI_PROJECT_ID = "${{ secrets.AZURE_EXISTING_AI_PROJECT_RESOURCE_ID }}"
}

Write-Host "AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID: $EXP_LOG_ANALYTICS_ID"
Expand All @@ -305,22 +305,77 @@ jobs:

# Get deployment outputs using azd
Write-Host "Extracting deployment outputs..."
$DEPLOY_OUTPUT = azd env get-values --output json | ConvertFrom-Json
Write-Host "Deployment output: $($DEPLOY_OUTPUT | ConvertTo-Json -Depth 10)"

if (-not $DEPLOY_OUTPUT) {
Write-Host "Error: Deployment output is empty. Please check the deployment logs."
exit 1
}

$API_APP_URL = $DEPLOY_OUTPUT.API_APP_URL
$API_APP_URL = azd env get-value API_APP_URL
"API_APP_URL=$API_APP_URL" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
"API_APP_URL=$API_APP_URL" | Out-File -FilePath $env:GITHUB_OUTPUT -Encoding utf8 -Append

$WEB_APP_URL = $DEPLOY_OUTPUT.WEB_APP_URL
$WEB_APP_URL = azd env get-value WEB_APP_URL
"WEB_APP_URL=$WEB_APP_URL" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
"WEB_APP_URL=$WEB_APP_URL" | Out-File -FilePath $env:GITHUB_OUTPUT -Encoding utf8 -Append

- name: Install ODBC Driver 18 for SQL Server
shell: pwsh
run: |
Write-Host "Installing ODBC Driver 18 for SQL Server on Windows..."

# Download and install the ODBC Driver installer with error handling
$installerUrl = "https://go.microsoft.com/fwlink/?linkid=2249004"
$installerPath = "$env:TEMP\msodbcsql.msi"

try {
Write-Host "Downloading ODBC Driver installer from $installerUrl ..."
Invoke-WebRequest -Uri $installerUrl -OutFile $installerPath -UseBasicParsing -ErrorAction Stop

if (-not (Test-Path $installerPath)) {
throw "ODBC Driver installer was not downloaded to expected path: $installerPath"
}

Write-Host "Running ODBC Driver installer..."
$msiArgs = "/i `"$installerPath`" /quiet IACCEPTMSODBCSQLLICENSETERMS=YES"
$process = Start-Process msiexec.exe -ArgumentList $msiArgs -Wait -NoNewWindow -PassThru

if ($process.ExitCode -ne 0) {
throw "ODBC Driver installer exited with code $($process.ExitCode)."
}

Write-Host "✅ ODBC Driver 18 installation complete"
}
catch {
Write-Error "Failed to install ODBC Driver 18 for SQL Server: $($_.Exception.Message)"
if (Test-Path $installerPath) {
Remove-Item $installerPath -Force -ErrorAction SilentlyContinue
}
exit 1
}
finally {
if (Test-Path $installerPath) {
Remove-Item $installerPath -Force -ErrorAction SilentlyContinue
}
}

- name: Process Sample Data
id: process_sample_data
continue-on-error: true
shell: bash
env:
PYTHONIOENCODING: utf-8
run: |
echo "Running process_sample_data.sh..."
bash ./infra/scripts/process_sample_data.sh
echo "✅ Sample data processing completed successfully."

- name: Retry Process Sample Data
if: steps.process_sample_data.outcome == 'failure'
shell: bash
env:
PYTHONIOENCODING: utf-8
run: |
echo "⚠️ First attempt failed. Retrying process_sample_data.sh..."
sleep 20
bash ./infra/scripts/process_sample_data.sh
echo "✅ Sample data processing completed successfully on retry."

- name: Generate Deployment Summary
if: always()
shell: bash
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/job-docker-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ jobs:

- name: Build and Push Docker Image for WebApp
uses: docker/build-push-action@v6
env:
DOCKER_BUILD_SUMMARY: false
with:
context: ./src/App
file: ./src/App/WebApp.Dockerfile
Expand All @@ -66,6 +68,8 @@ jobs:

- name: Build and Push Docker Image for API
uses: docker/build-push-action@v6
env:
DOCKER_BUILD_SUMMARY: false
with:
context: ./src/api
file: ./src/api/ApiApp.Dockerfile
Expand Down
71 changes: 67 additions & 4 deletions .github/workflows/job-test-automation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,47 @@ jobs:
attempt=$((attempt + 1))
done

- name: Validate Use Case and Test Suite
run: |
echo "Validating use case: '${{ env.azure_env_use_case }}'"
echo "Validating test suite: '${{ env.test_suite }}'"

# Validate use case
if [ -z "${{ env.azure_env_use_case }}" ]; then
echo "ERROR: AZURE_ENV_USE_CASE is empty or not provided"
exit 1
elif [ "${{ env.azure_env_use_case }}" != "telecom" ] && [ "${{ env.azure_env_use_case }}" != "IT_helpdesk" ]; then
echo "ERROR: Invalid AZURE_ENV_USE_CASE '${{ env.azure_env_use_case }}'. Must be 'telecom' or 'IT_helpdesk'"
exit 1
fi

# Validate test suite
if [ -z "${{ env.test_suite }}" ]; then
echo "ERROR: TEST_SUITE is empty or not provided"
exit 1
elif [ "${{ env.test_suite }}" != "GoldenPath-Testing" ] && [ "${{ env.test_suite }}" != "Smoke-Testing" ]; then
echo "ERROR: Invalid TEST_SUITE '${{ env.test_suite }}'. Must be 'GoldenPath-Testing' or 'Smoke-Testing'"
exit 1
fi

echo "✅ Use case '${{ env.azure_env_use_case }}' and test suite '${{ env.test_suite }}' are valid"

- name: Run tests(1)
id: test1
run: |
xvfb-run pytest --headed --html=report/report.html --self-contained-html
if [ "${{ env.azure_env_use_case }}" == "telecom" ]; then
if [ "${{ env.test_suite }}" == "GoldenPath-Testing" ]; then
xvfb-run pytest tests/test_telecom_gp_tc.py --headed --html=report/report.html --self-contained-html
elif [ "${{ env.test_suite }}" == "Smoke-Testing" ]; then
xvfb-run pytest tests/test_telecom_gp_tc.py tests/test_telecom_smoke_tc.py --headed --html=report/report.html --self-contained-html
fi
elif [ "${{ env.azure_env_use_case }}" == "IT_helpdesk" ]; then
if [ "${{ env.test_suite }}" == "GoldenPath-Testing" ]; then
xvfb-run pytest tests/test_ithelpdesk_gp_tc.py --headed --html=report/report.html --self-contained-html
elif [ "${{ env.test_suite }}" == "Smoke-Testing" ]; then
xvfb-run pytest tests/test_ithelpdesk_gp_tc.py tests/test_ithelpdesk_smoke_tc.py --headed --html=report/report.html --self-contained-html
fi
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test execution logic does not handle the case where neither 'telecom' nor 'IT_helpdesk' use cases are specified. If azure_env_use_case has a different value or is empty, no tests will be executed, but the step will silently succeed. This could lead to false positives where the test step appears to pass but no tests were actually run. Consider adding an else clause to handle unknown use cases or adding validation to ensure a valid use case is provided.

Suggested change
fi
fi
else
echo "ERROR: Unknown or unsupported azure_env_use_case: '${{ env.azure_env_use_case }}'. No tests were run."
exit 1

Copilot uses AI. Check for mistakes.
fi
Comment on lines +129 to +141
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is significant code duplication in the test execution logic across test1, test2, and test3 steps. The same nested if-elif structure is repeated three times (lines 129-141, 154-166, 179-191). Consider extracting this logic into a reusable script or using a GitHub Actions composite action to reduce duplication and improve maintainability.

Copilot uses AI. Check for mistakes.
working-directory: tests/e2e-test
continue-on-error: true

Expand All @@ -114,7 +151,19 @@ jobs:
if: ${{ steps.test1.outcome == 'failure' }}
id: test2
run: |
xvfb-run pytest --headed --html=report/report.html --self-contained-html
if [ "${{ env.azure_env_use_case }}" == "telecom" ]; then
if [ "${{ env.test_suite }}" == "GoldenPath-Testing" ]; then
xvfb-run pytest tests/test_telecom_gp_tc.py --headed --html=report/report.html --self-contained-html
elif [ "${{ env.test_suite }}" == "Smoke-Testing" ]; then
xvfb-run pytest tests/test_telecom_gp_tc.py tests/test_telecom_smoke_tc.py --headed --html=report/report.html --self-contained-html
fi
elif [ "${{ env.azure_env_use_case }}" == "IT_helpdesk" ]; then
if [ "${{ env.test_suite }}" == "GoldenPath-Testing" ]; then
xvfb-run pytest tests/test_ithelpdesk_gp_tc.py --headed --html=report/report.html --self-contained-html
elif [ "${{ env.test_suite }}" == "Smoke-Testing" ]; then
xvfb-run pytest tests/test_ithelpdesk_gp_tc.py tests/test_ithelpdesk_smoke_tc.py --headed --html=report/report.html --self-contained-html
fi
fi
working-directory: tests/e2e-test
continue-on-error: true

Expand All @@ -127,7 +176,19 @@ jobs:
if: ${{ steps.test2.outcome == 'failure' }}
id: test3
run: |
xvfb-run pytest --headed --html=report/report.html --self-contained-html
if [ "${{ env.azure_env_use_case }}" == "telecom" ]; then
if [ "${{ env.test_suite }}" == "GoldenPath-Testing" ]; then
xvfb-run pytest tests/test_telecom_gp_tc.py --headed --html=report/report.html --self-contained-html
elif [ "${{ env.test_suite }}" == "Smoke-Testing" ]; then
xvfb-run pytest tests/test_telecom_gp_tc.py tests/test_telecom_smoke_tc.py --headed --html=report/report.html --self-contained-html
fi
elif [ "${{ env.azure_env_use_case }}" == "IT_helpdesk" ]; then
if [ "${{ env.test_suite }}" == "GoldenPath-Testing" ]; then
xvfb-run pytest tests/test_ithelpdesk_gp_tc.py --headed --html=report/report.html --self-contained-html
elif [ "${{ env.test_suite }}" == "Smoke-Testing" ]; then
xvfb-run pytest tests/test_ithelpdesk_gp_tc.py tests/test_ithelpdesk_smoke_tc.py --headed --html=report/report.html --self-contained-html
fi
fi
working-directory: tests/e2e-test

- name: Upload test report
Expand All @@ -137,7 +198,9 @@ jobs:
with:

name: test-report-${{ github.run_id }}
path: tests/e2e-test/report/*
path: |
tests/e2e-test/report/*
tests/e2e-test/screenshots/*

- name: Generate E2E Test Summary
if: always()
Expand Down
3 changes: 3 additions & 0 deletions infra/main.parameters.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@
},
"frontendContainerRegistryHostname": {
"value": "${AZURE_ENV_CONTAINER_REGISTRY_ENDPOINT}"
},
"usecase":{
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter definition for "usecase" is inconsistently formatted compared to other parameters in this file. It uses "usecase" as the key name, while most parameters in the codebase appear to follow camelCase convention (e.g., "solutionName", "resourceGroupName"). Consider using "useCase" instead of "usecase" for consistency with the existing naming pattern, or ensure this matches the expected parameter name in the infrastructure templates.

Suggested change
"usecase":{
"useCase":{

Copilot uses AI. Check for mistakes.
"value": "${AZURE_ENV_USE_CASE}"
}
}
}
3 changes: 3 additions & 0 deletions infra/main.waf.parameters.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@
},
"virtualMachineAdminPassword": {
"value": "${AZURE_ENV_VM_ADMIN_PASSWORD}"
},
"usecase":{
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter definition for "usecase" is inconsistently formatted compared to other parameters in this file. It uses "usecase" as the key name, while most parameters in the codebase appear to follow camelCase convention (e.g., "solutionName", "enableTelemetry"). Consider using "useCase" instead of "usecase" for consistency with the existing naming pattern, or ensure this matches the expected parameter name in the infrastructure templates.

Suggested change
"usecase":{
"useCase":{

Copilot uses AI. Check for mistakes.
"value": "${AZURE_ENV_USE_CASE}"
}
}
}
Loading
Loading