Skip to content

Comments

refactor: separate search service module to enable managed identity to reduce deployment time#771

Open
Harsh-Microsoft wants to merge 4 commits intodevfrom
hb-psl-reduce-srch-time
Open

refactor: separate search service module to enable managed identity to reduce deployment time#771
Harsh-Microsoft wants to merge 4 commits intodevfrom
hb-psl-reduce-srch-time

Conversation

@Harsh-Microsoft
Copy link
Contributor

Purpose

This pull request refactors the deployment of the Azure Search Service in the infra/main.bicep file to improve modularity and enable managed identity more efficiently. The main changes include splitting the search service deployment into two separate modules, updating references throughout the code to use the new module names, and ensuring role assignments and connections reference the correct outputs.

Refactor and modularization of Azure Search Service deployment:

  • Split the search service deployment into two modules: searchService for the main deployment with all parameters and searchServiceEnableIdentity for enabling managed identity, improving deployment speed and modularity.
  • Updated all references from the old searchSearchServices module to the new searchService and searchServiceEnableIdentity modules, ensuring that outputs such as resourceId, location, and systemAssignedMIPrincipalId are correctly used throughout the deployment. [1] [2] [3] [4]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant