refactor: separate search service module to enable managed identity to reduce deployment time#771
Open
Harsh-Microsoft wants to merge 4 commits intodevfrom
Open
refactor: separate search service module to enable managed identity to reduce deployment time#771Harsh-Microsoft wants to merge 4 commits intodevfrom
Harsh-Microsoft wants to merge 4 commits intodevfrom
Conversation
…o reduce deployment time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refactors the deployment of the Azure Search Service in the
infra/main.bicepfile to improve modularity and enable managed identity more efficiently. The main changes include splitting the search service deployment into two separate modules, updating references throughout the code to use the new module names, and ensuring role assignments and connections reference the correct outputs.Refactor and modularization of Azure Search Service deployment:
searchServicefor the main deployment with all parameters andsearchServiceEnableIdentityfor enabling managed identity, improving deployment speed and modularity.searchSearchServicesmodule to the newsearchServiceandsearchServiceEnableIdentitymodules, ensuring that outputs such asresourceId,location, andsystemAssignedMIPrincipalIdare correctly used throughout the deployment. [1] [2] [3] [4]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information