Skip to content

Document banned npm names #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 2 commits into from
Jan 25, 2022
Merged

Document banned npm names #381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8b622e
Document banned npm names
LinqLover Jan 15, 2022
8c6c8e3
Update link to PR
LinqLover Jan 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/dtslint/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,15 @@ function assertPathIsInDefinitelyTyped(dirPath: string): void {
}
}

/**
* Starting at some point in time, npm has banned all new packages whose names
* contain the word `download`. However, some older packages exist that still
* contain this name.
* @NOTE for contributors: The list of literal exceptions below should ONLY be
* extended with packages for which there already exists a corresponding type
* definition package in the `@types` scope. More information:
* https://github.com/microsoft/DefinitelyTyped-tools/pull/381.
*/
function assertPathIsNotBanned(dirPath: string) {
const basedir = basename(dirPath);
if (
Expand Down