Added debug info for localized global variables for inlined scopes. #7799
+347
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
llvm-beanz
reviewed
Oct 8, 2025
tools/clang/test/HLSLFileCheck/dxil/debug/local_global_inline_scope.hlsl
Show resolved
Hide resolved
damyanp
approved these changes
Nov 13, 2025
Member
There was a problem hiding this comment.
LGTM
FWIW, I wasn't sure what the .ll test was testing (mostly through my ignorance), but I checked out the branch and reverted the functional changes and that test started failing, which convinced me at least that it is testing something.
I would recommend getting a review from someone more familiar with the codebase than I am!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, global variables converted to
alloca's, their debug info is written as adbg.valuefor a fake local variable prefixed with "global.". This was only done for the entry function'sDISubprogram, which makes the variable inaccessible for all inlined function scopes.This change creates a
dbg.valuefor each inlinedDISubprogram, each pointing to a newDILocalVariablewith the inlinedDISubprogramas its scope.