DXC: fix ObjC rewrite for HLSL function types + enable modern CMake policies + clang format fixes #7920
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olicies - Added clang/Basic/Specifiers.h and passed the required ArrayRef<hlsl::ParameterModifier> to ASTContext::getFunctionType. This fixes the Clang ObjC rewrite helper when HLSL’s function-signature extensions are enabled, so upstream LLVM/DXC users would hit the same issue. - Added enforcement for CMP0051/CMP0056/CMP0063/CMP0077 to NEW. That removes deprecated policy warnings for anyone building DXC with modern CMake, so it’s a generic build-system cleanup upstream will likely appreciate.
Member
|
Hi - thank you for your contribution. I've not looked at this in detail, but have two high-level pieces of feedback:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clang/Basic/Specifiers.h and passed the required ArrayRefhlsl::ParameterModifier to ASTContext::getFunctionType. This fixes the Clang ObjC rewrite helper when HLSL’s function-signature extensions are enabled, so upstream LLVM/DXC users would hit the same issue.
Added enforcement for CMP0051/CMP0056/CMP0063/CMP0077 to NEW. That removes deprecated policy warnings for anyone building DXC with modern CMake.