Fix double-increment bug in LegalizeResources when looping over PHIs #7934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This subtle bug can cause a failure to resolve a static resource in a corner case where DxilValueCache could replace an odd-indexed phi, and this is needed to resolve other phis to known values, but an indexing bug prevents the loop from ever visiting any phi nodes at odd-numbered indexes in the list. This change also adds two IR-based pass tests for this code path, as there weren't any before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This subtle bug can cause a failure to resolve a static resource in a corner case where DxilValueCache could replace an odd-indexed phi, and this is needed to resolve other phis to known values, but an indexing bug prevents the loop from ever visiting any phi nodes at odd-numbered indexes in the list.
This change also adds two IR-based pass tests for this code path, as there weren't any before.