Skip to content

Conversation

@alsepkow
Copy link
Contributor

This PR resolves #7471
All new tests were validated against a local build of WARP with fixes for the quad and derivative ops with long vector arguments.

Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorial things in comments. I trust you've verified the test is testing what you expect it to.

LGTM

@alsepkow
Copy link
Contributor Author

alsepkow commented Nov 21, 2025 via email

Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not sufficient to test these ops generally, for the purposes of testing that the additional overloads are supported it should suffice.

@alsepkow
Copy link
Contributor Author

While not sufficient to test these ops generally, for the purposes of testing that the additional overloads are supported it should suffice.

Discussed offline. We will start with this and discuss adding more in-depth coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

Long Vector Execution Tests: Derivative and Quad Operators

3 participants