-
Notifications
You must be signed in to change notification settings - Fork 808
Execution Tests: Long Vector - Add basic derivative and quad op tests #7938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
damyanp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some editorial things in comments. I trust you've verified the test is testing what you expect it to.
LGTM
Co-authored-by: Damyan Pepper <[email protected]>
Co-authored-by: Damyan Pepper <[email protected]>
|
Yup, I spent some time debugging and interacting with WARP to make sure these were doing what I expected.
________________________________
From: Damyan Pepper ***@***.***>
Sent: Thursday, November 20, 2025 5:00 PM
To: microsoft/DirectXShaderCompiler ***@***.***>
Cc: Alex Sepkowski ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft/DirectXShaderCompiler] Execution Tests: Long Vector - Add basic derivative and quad op tests (PR #7938)
@damyanp approved this pull request.
Some editorial things in comments. I trust you've verified the test is testing what you expect it to.
LGTM
________________________________
In tools/clang/unittests/HLSLExec/LongVectors.cpp<#7938 (comment)>:
+// The lane we write to is determined via a defines in the shader code via a
+// defines. See TestQuadRead in ShaderOpArith.xml.
⬇️ Suggested change
-// The lane we write to is determined via a defines in the shader code via a
-// defines. See TestQuadRead in ShaderOpArith.xml.
+// The lane we write to is determined via a defines in the shader code.
+// See TestQuadRead in ShaderOpArith.xml.
________________________________
In tools/clang/unittests/HLSLExec/ShaderOpArith.xml<#7938 (comment)>:
@@ -4247,8 +4247,67 @@ void MSMain(uint GID : SV_GroupIndex,
}
#endif
- #ifdef NUMTHREADS_X
- #define NUMTHREADS_ATTR [numthreads(NUMTHREADS_X, 1, 1)]
+ #ifdef FUNC_TEST_DERIVATIVE
+ void TestDerivative(vector<TYPE, NUM> Vector)
+ {
+ // 0 == upper-left lane in quad
+ // 1 == upper-right lane in quad
+ // 2 == lower-left lane in quad
+ // 3 == lower-right lane in quad
+
+ const uint LaneIndex = WaveGetLaneIndex();
+
+ // We need to make the values are unique across lanes used in the
⬇️ Suggested change
- // We need to make the values are unique across lanes used in the
+ // We need to make sure the values are unique across lanes used in the
—
Reply to this email directly, view it on GitHub<#7938 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABK4EW7RYXOERUBRGPUFTTT35ZPZZAVCNFSM6AAAAACMYDO3QSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIOJQG4YTCNBWG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
tex3d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While not sufficient to test these ops generally, for the purposes of testing that the additional overloads are supported it should suffice.
Discussed offline. We will start with this and discuss adding more in-depth coverage. |
This PR resolves #7471
All new tests were validated against a local build of WARP with fixes for the quad and derivative ops with long vector arguments.