Allow derivatives in coalescing nodes #7942
Open
+31
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the spec ( https://github.com/microsoft/DirectX-Specs/blob/master/d3d/WorkGraphs.md#quad-and-derivative-operation-semantics ) derivatives are allowed in all but thread launch nodes, but the validator disallowed them in coalescing nodes. This changes the validator to allow derivatives in coalescind nodes and adds testing for derivatives in coalescing and broadcast nodes. Fixes microsoft#7723
| #define AS 2 | ||
| #define MS 3 | ||
| #define BNS 4 | ||
| #define CNS 5 |
Collaborator
There was a problem hiding this comment.
Add an error check if we try to use derivatives with Thread Launch?
Collaborator
Author
There was a problem hiding this comment.
I had the same thought! But that test already exists: https://github.com/microsoft/DirectXShaderCompiler/blob/main/tools/clang/test/HLSLFileCheck/validation/callgraph/deriv-in-nested-fn-node-lib68-launch.ll#L6
| res += input.SampleCmp(cmpSamp, uv, cmpVal, uint2(-3, 4)); | ||
| res += input.SampleCmp(cmpSamp, uv, cmpVal, uint2(-4, 6), DTid.z); | ||
| res += input.SampleCmp(cmpSamp, uv, cmpVal, uint2(-5, 7), DTid.z, status); | ||
| res += input.SampleCmp(cmpSamp, uv, cmpVal, uint2(-4, 6), GI); |
Collaborator
There was a problem hiding this comment.
why was this needed?
Collaborator
Author
There was a problem hiding this comment.
I suppose it wasn't if I just converted the GTid that replaced DTid with uint3. That replacement took place because all launch types support that semantic value and coalescing doesn't support DispatchThreadID. The uses are pretty arbitrary, just using what values are available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the spec ( https://github.com/microsoft/DirectX-Specs/blob/master/d3d/WorkGraphs.md#quad-and-derivative-operation-semantics ) derivatives are allowed in all but thread launch nodes, but the validator disallowed them in coalescing nodes.
This changes the validator to allow derivatives in coalescind nodes and adds testing for derivatives in coalescing and broadcast nodes.
Fixes #7723