Repository navigation
chore: Update SPIR-V dependencies - #9147
Closed
Ashley Coleman (V-FEXrt) wants to merge 1 commit into
Closed
Ashley Coleman (V-FEXrt) wants to merge 1 commit into
Ashley Coleman (V-FEXrt) wants to merge 1 commit into
Conversation
Update SPIRV-Tools to `v2026.4.rc2` and SPIRV-Headers to the matching revision declared by SPIRV-Tools. --------- Copilot-Session: fe7b89a0-1034-4117-be61-55ec3d9e9f19 Copilot-Session: f12a72d2-e956-4ca9-a301-5caca8d1b353
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The diff updates only printf test expectations, leaving the described SPIRV-Tools and SPIRV-Headers dependency alignment unaddressed or the PR scope unclear.
1 open issue
What changed in this PR
Supports the planned SPIR-V dependency alignment with the release branch by updating expected printf disassembly in the compiler’s regression tests.
Changes:
- Replace numeric opcode
1with theDebugPrintfmnemonic in six FileCheck assertions.
| File | Description |
|---|---|
tools/clang/test/CodeGenSPIRV/intrinsics.printf.hlsl |
Updates printf checks to expect the symbolic instruction name. |
Review effort: Balanced
| [numthreads(1,1,1)] | ||
| void main() { | ||
| // CHECK: {{%[0-9]+}} = OpExtInst %void [[set]] 1 [[format1]] | ||
| // CHECK: {{%[0-9]+}} = OpExtInst %void [[set]] DebugPrintf [[format1]] |
Collaborator
Author
|
Dupe of #9146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Updates the SPIR-V deps on main to match the latest release branch