Skip to content

chore: Update SPIR-V dependencies - #9147

Closed
Ashley Coleman (V-FEXrt) wants to merge 1 commit into
microsoft:mainfrom
V-FEXrt:spirv-sync
Closed

Ashley Coleman (V-FEXrt) wants to merge 1 commit into
microsoft:mainfrom
V-FEXrt:spirv-sync

Conversation

@V-FEXrt

Copy link
Copy Markdown
Collaborator

Updates the SPIR-V deps on main to match the latest release branch

Update SPIRV-Tools to `v2026.4.rc2` and SPIRV-Headers to the matching
revision declared by SPIRV-Tools.

---------

Copilot-Session: fe7b89a0-1034-4117-be61-55ec3d9e9f19
Copilot-Session: f12a72d2-e956-4ca9-a301-5caca8d1b353

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The diff updates only printf test expectations, leaving the described SPIRV-Tools and SPIRV-Headers dependency alignment unaddressed or the PR scope unclear.

1 open issue
What changed in this PR

Supports the planned SPIR-V dependency alignment with the release branch by updating expected printf disassembly in the compiler’s regression tests.

Changes:

  • Replace numeric opcode 1 with the DebugPrintf mnemonic in six FileCheck assertions.
File Description
tools/​clang/​test/​CodeGenSPIRV/​intrinsics.printf.hlsl Updates printf checks to expect the symbolic instruction name.

Review effort: Balanced

[numthreads(1,1,1)]
void main() {
// CHECK: {{%[0-9]+}} = OpExtInst %void [[set]] 1 [[format1]]
// CHECK: {{%[0-9]+}} = OpExtInst %void [[set]] DebugPrintf [[format1]]
@V-FEXrt

Copy link
Copy Markdown
Collaborator Author

Dupe of #9146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants