Skip to content

feat: Add Tooltip for necessary icons #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NirajC-Microsoft wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add Tooltip for necessary icons #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion App/frontend-app/src/components/chat/chatRoom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,9 @@ export function ChatRoom({ searchResultDocuments, selectedDocuments, chatWithDoc
disabled={isLoading}
onSubmit={handleSend}
disableSend = {textAreaValue.trim().length === 0 || isLoading}
contentAfter={undefined}
send={{
title: "Send"
}}
/>
</div>
</div >
Expand Down
16 changes: 9 additions & 7 deletions App/frontend-app/src/components/documentViewer/dialogTitleBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { useState, useEffect } from 'react';
import { Button, Divider, Text, Tab, TabList, SelectTabEvent, SelectTabData, DialogTrigger } from '@fluentui/react-components';
import { Button, Divider, Text, Tab, TabList, SelectTabEvent, SelectTabData, DialogTrigger, Tooltip } from '@fluentui/react-components';
import { Dismiss24Regular, ArrowHookDownLeft16Filled, SparkleFilled, DocumentBulletListMultipleRegular, DocumentBulletListRegular, LayerDiagonalSparkle24Regular, InfoRegular } from '@fluentui/react-icons';
import { DialogTitle } from '@fluentui/react-components';
import { KMBrandRamp } from '../../styles';
Expand Down Expand Up @@ -66,12 +66,14 @@ export function DialogTitleBar({
style={{ width: "100%" }}
action={
<DialogTrigger action="close">
<Button
appearance="subtle"
aria-label="close"
icon={<Dismiss24Regular />}
onClick={handleDialogClose}
/>
<Tooltip content="Close" relationship="label" withArrow>
<Button
appearance="subtle"
aria-label="close"
icon={<Dismiss24Regular />}
onClick={handleDialogClose}
/>
</Tooltip>
</DialogTrigger>
}
>
Expand Down
16 changes: 13 additions & 3 deletions App/frontend-app/src/components/pagination/pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Button } from "@fluentui/react-components";
import { Button, Tooltip } from "@fluentui/react-components";
import { DOTS, usePagination } from "../../utils/customHooks/usePagination";
import { useState } from "react";
import { ChevronLeft24Regular, ChevronRight24Regular } from "@fluentui/react-icons";
Expand Down Expand Up @@ -55,9 +55,19 @@ export function Pagination({ totalCount, pageSize, currentPage, siblingCount = 1

return (
<ul className="flex flex-wrap">
<Button icon={<ChevronLeft24Regular />} className="h-8" appearance="subtle" onClick={onPrevious} disabled={isDisabled || isLeftArrowDisabled}></Button>
<Tooltip
content="Previous"
relationship="label"
withArrow>
<Button icon={<ChevronLeft24Regular />} className="h-8" appearance="subtle" onClick={onPrevious} disabled={isDisabled || isLeftArrowDisabled}></Button>
</Tooltip>
{items}
<Button icon={<ChevronRight24Regular />} className="h-8" appearance="subtle" onClick={onNext} disabled={isDisabled || isRightArrowDisabled}></Button>
<Tooltip
content="Next"
relationship="label"
withArrow>
<Button icon={<ChevronRight24Regular />} className="h-8" appearance="subtle" onClick={onNext} disabled={isDisabled || isRightArrowDisabled}></Button>
</Tooltip>
</ul>
);
}