Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply whitespace changes from new ESLint config #10056

Merged
merged 10 commits into from
Apr 28, 2022

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Apr 26, 2022

This PR applies fixes for ESLint formatting rules that will be part of the default lint config (see #9976). These are formatting only rules, specifically ones that deal only with whitespace. This PR represents no functional changes.

Most of the fixes were auto-fixes, with the exception of some function spacing issues that spanned lines.

The rules applied are:

        "@typescript-eslint/brace-style": [
            "warn",
            "1tbs",
            {
                "allowSingleLine": true,
            },
        ],
        "@typescript-eslint/comma-spacing": "error",
        "@typescript-eslint/func-call-spacing": "error",
        "@typescript-eslint/keyword-spacing": "error",
        "@typescript-eslint/object-curly-spacing": [
            "error",
            "always",
        ],
        "@typescript-eslint/space-before-function-paren": [
            "error",
            {
                "anonymous": "never",
                "asyncArrow": "always",
                "named": "never"
            }
        ],
        "@typescript-eslint/space-infix-ops": "error",
        "@typescript-eslint/type-annotation-spacing": "error",
        "array-bracket-spacing": "error",
        "arrow-spacing": "error",
        "block-spacing": "error",
        "key-spacing": "error",

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: definitions area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Apr 26, 2022
@tylerbutler tylerbutler marked this pull request as ready for review April 28, 2022 00:14
@tylerbutler tylerbutler requested review from msfluid-bot and a team as code owners April 28, 2022 00:14
@tylerbutler tylerbutler merged commit 83ccb6a into microsoft:main Apr 28, 2022
@tylerbutler tylerbutler deleted the lint/apply-formatting-01 branch April 28, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: propertydds area: dds: sharedstring area: dds Issues related to distributed data structures area: definitions area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants