Fix for SharedTree op named idAllocation #21867
Open
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 38edc9b |
tylerbutler
requested review from
a team,
pragya91,
markfields,
agarwal-navin,
jatgarg,
tyler-cai-microsoft,
kian-thompson and
rajatch-ff
and removed request for
a team
markfields
reviewed
Jul 23, 2024
| @@ -607,8 +607,8 @@ function processOp( | |||
| type: string; | |||
| }; | |||
| const address = envelope.address; | |||
| type = `${type}/${innerContent.type}`; | |||
| switch (innerContent.type) { | |||
| type = `${type}/${innerContent?.type}`; | |||
There was a problem hiding this comment.
Looking this over, all this code only applies to FluidDataStoreOp. I'd pull the other 3 to their own case chunk and have it do nothing or whatever makes sense.
You'll be able to remove several as's (e.g. as IEnvelope on line 600) this way too, because the types express the type of contents
There was a problem hiding this comment.
And revert the addition of ?
Friendly ping, @arafat-java, in case you want to come back to this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21866
When fetch-tool is used to fetch all the ops it fails to fetch block of type="idAllocation" associated with SharedTree
This op usually comes with sequenceNumber=2 with Brainstorm sample app
More details around error log and reproduction steps can be found in bug/issue #21866