refactor(routerlicious): use strictNullChecks #23054
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-orderer, protocol-base, routerlicious
znewton
requested review from
pradeepvairamani,
zhangxin511,
shubhi1092,
yunho-microsoft,
kekachmar and
dhr-verma
github-actions
bot
added
area: server
frankmueller-msft
requested review from
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 109 out of 124 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- server/routerlicious/packages/gitresources/tsconfig.json: Language not supported
- server/routerlicious/packages/kafka-orderer/tsconfig.json: Language not supported
- server/routerlicious/packages/lambdas-driver/tsconfig.json: Language not supported
- server/routerlicious/packages/local-server/tsconfig.json: Language not supported
- server/routerlicious/packages/memory-orderer/tsconfig.json: Language not supported
- server/routerlicious/packages/protocol-base/tsconfig.json: Language not supported
- server/routerlicious/packages/routerlicious-base/package.json: Language not supported
- server/routerlicious/packages/lambdas-driver/src/test/types/validateServerLambdasDriverPrevious.generated.ts: Evaluated as low risk
- server/routerlicious/packages/routerlicious-base/src/alfred/routes/api/documents.ts: Evaluated as low risk
- server/routerlicious/packages/routerlicious-base/src/alfred/routes/api/deltas.ts: Evaluated as low risk
- server/routerlicious/packages/lambdas-driver/src/document-router/lambdaFactory.ts: Evaluated as low risk
- server/routerlicious/packages/memory-orderer/src/localOrderManager.ts: Evaluated as low risk
- server/routerlicious/packages/routerlicious-base/src/alfred/routes/api/api.ts: Evaluated as low risk
- server/routerlicious/packages/memory-orderer/src/reservationManager.ts: Evaluated as low risk
- server/routerlicious/packages/memory-orderer/src/nodeManager.ts: Evaluated as low risk
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting TSConfig
strictNullChecks: truecan help avoid numerous runtime errors by catching unhandlednull/undefinedcases at compiletime. R11s has had this disabled for a very long time, and the code has not handled nulls very well because of it.This PR
Breaking Changes
Many types now have
| nullor| undefinedadded to reflect the actual, implemented return/param values. Behavior should not be changing, but types are.Reviewer Guidance
This ended up being a large PR. I tried to keep the changes focused purely to handling undefined and null explicitly. This ended up requiring that I add a lot of
| nullandeslint-ignore-next-line @rushstack/no-new-null. These should be switched to| undefinedwith explicit conversion ofnull -> undefinedwhere needed, but I did not want to rock the boat too much.