Revert "Revert "Enable noUncheckedIndexedAccess for DDSes excluding tree and merge-tree (#21420)" and disable noUncheckedIndexedAccess"

[RishhiB]

Reverts #22378

[msfluid-bot]

Code Coverage Summary

↓ packages.dds.ink.src:
Line Coverage Change: -0.68%    Branch Coverage Change: No change

Metric Name	Baseline coverage	PR coverage	Coverage Diff
Branch Coverage	93.54%	93.54%	→ No change
Line Coverage	54.42%	53.74%	↓ -0.68%

↓ packages.dds.matrix.src:
Line Coverage Change: -0.05%    Branch Coverage Change: No change

Metric Name	Baseline coverage	PR coverage	Coverage Diff
Branch Coverage	93.57%	93.57%	→ No change
Line Coverage	96.39%	96.34%	↓ -0.05%

↑ packages.dds.sequence.src:
Line Coverage Change: 0.02%    Branch Coverage Change: No change

Metric Name	Baseline coverage	PR coverage	Coverage Diff
Branch Coverage	89.53%	89.53%	→ No change
Line Coverage	89.87%	89.89%	↑ 0.02%

↑ packages.dds.map.src:
Line Coverage Change: 0.04%    Branch Coverage Change: No change

Metric Name	Baseline coverage	PR coverage	Coverage Diff
Branch Coverage	93.69%	93.69%	→ No change
Line Coverage	84.48%	84.52%	↑ 0.04%

---

Baseline commit: c7730cc
Baseline build: 306006
Happy Coding!!

Code coverage comparison check passed!!

[msfluid-bot]

⯆ @fluid-example/bundle-size-tests: -40 Bytes

Metric Name	Baseline Size	Compare Size	Size Diff
aqueduct.js	464.33 KB	464.31 KB	⯆ -23 Bytes
azureClient.js	563.18 KB	563.17 KB	⯆ -9 Bytes
connectionState.js	724 Bytes	724 Bytes	■ No change
containerRuntime.js	262.48 KB	262.5 KB	⯅ +14 Bytes
fluidFramework.js	426.84 KB	426.8 KB	⯆ -38 Bytes
loader.js	134.18 KB	134.19 KB	⯅ +14 Bytes
map.js	42.71 KB	42.66 KB	⯆ -45 Bytes
matrix.js	148.36 KB	148.36 KB	■ No change
odspClient.js	528.97 KB	528.96 KB	⯆ -9 Bytes
odspDriver.js	97.88 KB	97.9 KB	⯅ +21 Bytes
odspPrefetchSnapshot.js	42.81 KB	42.83 KB	⯅ +14 Bytes
sharedString.js	164.26 KB	164.27 KB	⯅ +7 Bytes
sharedTree.js	417.3 KB	417.3 KB	⯅ +7 Bytes
Total Size	3.37 MB	3.37 MB	⯆ -40 Bytes

---

Baseline commit: c7730cc

Generated by 🚫 dangerJS against 676661d

Copilot reviewed 6 out of 21 changed files in this pull request and generated no suggestions.

Files not reviewed (15)

• packages/dds/ink/tsconfig.json: Language not supported
• packages/dds/map/tsconfig.json: Language not supported
• packages/dds/matrix/tsconfig.json: Language not supported
• packages/dds/register-collection/tsconfig.json: Language not supported
• packages/dds/sequence/tsconfig.json: Language not supported
• packages/dds/map/src/map.ts: Evaluated as low risk
• packages/dds/matrix/src/sparsearray2d.ts: Evaluated as low risk
• packages/dds/sequence/src/sequenceDeltaEvent.ts: Evaluated as low risk
• packages/dds/matrix/src/matrix.ts: Evaluated as low risk
• packages/dds/map/src/directory.ts: Evaluated as low risk
• packages/dds/ink/src/snapshot.ts: Evaluated as low risk
• packages/dds/sequence/src/intervalCollection.ts: Evaluated as low risk
• packages/dds/map/src/mapKernel.ts: Evaluated as low risk
• packages/dds/matrix/src/permutationvector.ts: Evaluated as low risk
• packages/dds/sequence/src/sequence.ts: Evaluated as low risk

Comments skipped due to low confidence (3)

packages/dds/sequence/src/revertibles.ts:331

• Using non-null assertions here is risky. Ensure that removeRevertibles[0] is indeed non-null through proper validation.

mergeTreeRevertible: removeRevertibles[0]!;

packages/dds/matrix/src/handlecache.ts:113

• The TODO comment indicates uncertainty about the necessity of the non-null assertion. Investigate and clarify why the non-null assertion is needed here.

// TODO why are we non null asserting here?

packages/dds/matrix/src/handlecache.ts:123

• The TODO comment indicates uncertainty about the necessity of the non-null assertion. Investigate and clarify why the non-null assertion is needed here.

// TODO why are we non null asserting here?

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more