Use environment markers instead of modifying _install_requires

microsoft · Jan 10, 2020 · 34b1973 · 34b1973
1 parent ec36b19
commit 34b1973
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/src/python/setup.py b/src/python/setup.py
@@ -28,17 +28,13 @@
         'pandas>=0.22',
         'scipy>=0.18',
         'scikit-learn>0.19.0',
+        # dotnetcore2 package is available only for python 3.x
+        "dotnetcore2>=2.1.2;python_version>='3.0'",
+        "decorator;python_version<'3.0'",
+        "enum;python_version<'3.0'",
+        "funcsigs>=1.0.2;python_version<'3.0'",
     ]
 
-# dotnetcore2 package is available only for python 3.x
-if sys.version_info.major == 3:
-    _install_requires.append('dotnetcore2>=2.1.2')
-
-if sys.version_info[0:2] == (2,7):
-    _install_requires.append('decorator')
-    _install_requires.append('enum')
-    _install_requires.append('funcsigs>=1.0.2')
-
 setup(
     name='nimbusml',