Fix copy constructor for arrays and objects #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix `OpenApiArray` and `OpenApiObject` not copying their items when they are copied to a new instance. - Add tests for all built-in `IOpenApiAny` types with schema examples.
martincostello
requested review from
irvinesunday,
darrelmiller,
zengin,
coseguera,
millicentachieng,
MaggieKimani1 and
andrueastman
as code owners
MaggieKimani1
approved these changes
Jul 22, 2024
|
Thank you for the contribution! |
|
@MaggieKimani1 Do you know when the next stable release to NuGet.org will be? I'd like to start using the changes from this PR as well as #1717. If it isn't going to be soon, is there a pre-release feed someone I could use instead? |
|
Hey @martincostello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenApiArrayandOpenApiObjectnot copying their items when they are copied to a new instance.IOpenApiAnytypes with schema examples.Found as part of dotnet/aspnetcore#56318 (comment).