Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a label positioning bug in the DataRenderService by replacing the centroid-based label positioning with a more accurate line endpoint calculation system.
- Replaces
arc.centroid(d)calculations withthis.computeLabelLinePoints(d).lineEndPointfor more precise label positioning - Updates space availability calculations to include padding and use
Math.max(0, ...)to prevent negative values - Refactors the
isLabelsHasConflictfunction to return space availability data for reuse
Demonkratiy
approved these changes
Sep 26, 2025
Demonkratiy
added a commit
that referenced
this pull request
Feb 12, 2026
* v1.8.0.0 - Draw detail label lines starting from the element to accurately indicate what element it is related to. (#128) * Draw detail label lines starting from the element to accurately indicate what element it is related to. * Renamed several variables and implemented caching * Change version to 1.8.0.0 * Fix in changelog.md * Add formatting setting to show detail label name on the chart (#131) * Draw detail label lines starting from the element to accurately indicate what element it is related to. * Add formatting setting to show detail label name on the chart * Renamed several variables and implemented caching * Add Label Contents menu for labels also add logic to ensure inside labels fit within allowed space by truncating long text * Change lables contents dropdown to toggles Signed-off-by: v-aidaba <v-aidaba@microsoft.com> * PR review fixes * PR added displayName for lable position values * Changes for PR * Changes for PR * Changes for PR --------- Signed-off-by: v-aidaba <v-aidaba@microsoft.com> * Outer line (#130) * Draw detail label lines starting from the element to accurately indicate what element it is related to. * Renamed several variables and implemented caching * Change version to 1.8.0.0 * Draw gridlines without crossing the inner and outer circles * Change arc to circle for Outer line and draw gridlines without crossing the inner circle * Changes for better performance * Pull from origin branch --------- Co-authored-by: Alexey <39551830+Demonkratiy@users.noreply.github.com> * refactored detail labels to use flagsSelection (#134) * Conditional formatting (#137) * Conditional Formatting * Unit test position (#140) * added tests for labels position * Outer line unit test (#139) * outer line unit tests * PR checklist steps (#142) * PR checklist steps * Added support for label content in on-object formating API (#143) * New translations (#158) * added AI instructions and capabilities verification scripts (#160) * added AI instructions and capabilities verification scripts * exclude .github/** folder linting * update capabilities-check scripts (#162) * update capabilities-check scripts * update agent instructions * Enhance capabilities compatibility check workflow (#163) * Enhance capabilities compatibility check workflow Updated capabilities compatibility check workflow to correctly procced in case if no changes was present in capabilities. * update codeql * Fixed label bug (#159) * Fixed label bug Co-authored-by: Alexey <39551830+Demonkratiy@users.noreply.github.com> * updated outdated packages, also fixed npm audit and linter issues (#164) * @microsoft registry --------- Signed-off-by: v-aidaba <v-aidaba@microsoft.com> Co-authored-by: v-aidaba <v-aidaba@microsoft.com> Co-authored-by: pbicvloc <104190707+pbicvloc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.