Skip to content

Implemented gathering env information #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AleksSavelev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implemented gathering env information #550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions src/WebPackWrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { readJsonFromRoot, readJsonFromVisual } from './utils.js'

const config = await readJsonFromRoot('config.json');
const npmPackage = await readJsonFromRoot('package.json');
const visualPackage = await readJsonFromVisual('package.json');

const visualPlugin = "visualPlugin.ts";
const encoding = "utf8";
Expand Down Expand Up @@ -134,17 +135,6 @@ export default class WebPackWrap {
}
}

async getEnvironmentDetails() {
const env = {
nodeVersion: process.versions.node,
osPlatform: await os.platform(),
osVersion: await os.version ?? "undefined",
osReleaseVersion: await os.release(),
toolsVersion: npmPackage.version
};
return env;
}

async configureCustomVisualsWebpackPlugin(visualPackage, options, tsconfig) {
if (options.skipApiCheck) {
ConsoleWriter.warning(`Skipping API check. Tools started with --skipApi flag.`);
Expand All @@ -154,6 +144,7 @@ export default class WebPackWrap {

const api = await WebPackWrap.loadAPIPackage();
const dependenciesPath = typeof this.pbiviz.dependencies === "string" && path.join(process.cwd(), this.pbiviz.dependencies);
const environmentInformation = await this.getEnvironmentInformation(options);
let pluginConfiguration = {
...lodashCloneDeep(visualPackage.pbivizConfig),

Expand All @@ -175,10 +166,25 @@ export default class WebPackWrap {
compression: options.compression,
certificationAudit: options.certificationAudit,
certificationFix: options.certificationFix,
environmentInformation: environmentInformation
};
return pluginConfiguration;
}

async getEnvironmentInformation(options) {
const typescriptVersion = process.versions.typescript ??
visualPackage?.devDependencies?.typescript ??
visualPackage?.dependencies?.typescript;
const environmentInformation = {
typescript: typescriptVersion,
node: process.versions.node,
tools: npmPackage.version,
flags: JSON.stringify(options),
os: await os.platform()
};
return environmentInformation;
}

async configureAPIVersion() {
//(?<=powerbi-visuals-api@) - positive look-behind to find version installed in visual and get 3 level version.
const regexFullVersion = /(?<=powerbi-visuals-api@)((?:\d+\.?){1,3})/g;
Expand Down