[New utility]Sysinternals ZoomIt #35880
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
htcfreek
suggested changes
Nov 11, 2024
| </tkcontrols:SettingsExpander> | ||
| <tkcontrols:SettingsCard x:Uid="ZoomIt_Break_TimerOpacity"> | ||
| <ComboBox MinWidth="{StaticResource SettingActionControlMinWidth}" SelectedIndex="{x:Bind Path=ViewModel.BreakTimerOpacityIndex, Mode=TwoWay}"> | ||
| <ComboBoxItem>10%</ComboBoxItem> |
There was a problem hiding this comment.
Do we need localization for this?
| IsTabStop="{x:Bind ViewModel.IsEnabledGpoConfigured, Mode=OneWay}" | ||
| Severity="Informational" /> | ||
| <InfoBar | ||
| x:Uid="ZoomIt_SimultaneousStandaloneZoomItWarning" |
There was a problem hiding this comment.
Can we show this only if standalone version is really running? The we can severity warning.
|
|
||
| public bool IsEnabledGpoConfigured | ||
| { | ||
| get => _enabledStateIsGPOConfigured; |
There was a problem hiding this comment.
Suggested change
| get => _enabledStateIsGPOConfigured; | |
| get => _enabledStateIsGPOConfigured && _isEnabled; |
| OutGoingGeneralSettings snd = new OutGoingGeneralSettings(GeneralSettingsConfig); | ||
|
|
||
| SendConfigMSG(snd.ToString()); | ||
| OnPropertyChanged(nameof(IsEnabled)); |
There was a problem hiding this comment.
Suggested change
| OnPropertyChanged(nameof(IsEnabled)); | |
| OnPropertyChanged(nameof(IsEnabled)); | |
| OnPropertyChanged(nameof(IsEnabledGpoConfigured)); |
This comment has been minimized.
This comment has been minimized.
jaimecbernardo
force-pushed
the
dev/jaime/integrate-zoomIt
branch
from
3935ac9
to
01cd21c
Compare
This comment has been minimized.
This comment has been minimized.
jaimecbernardo
force-pushed
the
dev/jaime/integrate-zoomIt
branch
from
01cd21c
to
cf7dfd5
Compare
This comment has been minimized.
This comment has been minimized.
jaimecbernardo
force-pushed
the
dev/jaime/integrate-zoomIt
branch
from
cf7dfd5
to
fd84ff4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR integrates the Sysinternals tool ZoomIt into PowerToys.
Has the PowerToys Settings page with the options allowed from ZoomIt.
Also updates some C++ dependencies.
Still missing/WIP:
PR Checklist