[Color picker] Fix dashboard shortcut #37547
Open
+2
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantaionut
changed the title
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/settings-ui/Settings.UI/ViewModels/ColorPickerViewModel.cs:59
- The null-check for colorPickerSettingsRepository has been removed, which might lead to a runtime exception if it is null. Consider adding a null-check (or an explicit exception) similar to the one used for settingsUtils to ensure that colorPickerSettingsRepository is not null.
_colorPickerSettings = colorPickerSettingsRepository.SettingsConfig;
|
The functionality has been verified, and the issue has been resolved. Thank you for your contribution! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stefansjfw
approved these changes
Feb 21, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
1 similar comment
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stefansjfw
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fix Color picker dashboard not showing the correct shortcut.
PR Checklist
Detailed Description of the Pull Request / Additional comments
When creating the ColorPickerViewModel it was initialized with null instead of ColorPickerSettings settings.
So this PR changes it from null to ColorPickerSettings.
Validation Steps Performed
Tested by changing the shortcut for Color Picker and then checking in dashboard if the shortcut was changed there too.