Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] - auto fill parameters #37991

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

[Bug report] - auto fill parameters #37991

wants to merge 28 commits into from
+100 −13

Conversation

donlaci
Copy link
Collaborator

@donlaci donlaci commented Mar 17, 2025 •
edited
Loading

Summary of the Pull Request

Implementing auto fill the new issue template. The template has been modified: the admin dropbox has been removed and a new text area called "Additional information" has been added.
When clicking "Report a bug" from the General Settings page, the PT version is auto filled in the version text area and the following information are auto filled in the new "Additional information" text area:

  • OS version
  • .NET version
  • PT admin mode
  • PT install scope
  • OS language
  • OS locale

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

image

image

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
htcfreek
htcfreek reviewed Mar 17, 2025
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yml
@@ -66,7 +68,6 @@ body:
- Keyboard Manager
- Mouse Utilities
- Mouse Without Borders
- New+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htcfreek Thank you for highlighting this!

.github/ISSUE_TEMPLATE/bug_report.yml Outdated
@@ -79,7 +80,6 @@ body:
- TextExtractor
- Workspaces
- Welcome / PowerToys Tour window
- ZoomIt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing?

@shuaiyuanxx
Copy link
Contributor

There’s a same PR #33802 , we need to decide which should be in

@vanzue
Copy link
Contributor

vanzue commented Mar 20, 2025

What's the goal of this pr? Will it include runner bug report change?

@donlaci
Copy link
Collaborator Author

donlaci commented Mar 20, 2025

@shuaiyuanxx Yes, you should decide. If you ask me, I would vote for my PR.
It does one part what is done in the PR #33802 , The other half I'll try to implement in a separated PR, adding a popup window, which will pop up when the user selects the "report a bug" option from the taskbar icon.
@vanzue The goal of this PR is to auto fill the new issue template when the user clicks the "Report a bug" link in the settings/genral page.

@donlaci donlaci marked this pull request as ready for review March 20, 2025 14:06
@donlaci donlaci requested a review from a team as a code owner March 20, 2025 14:06
@vanzue vanzue self-requested a review March 20, 2025 14:07
vanzue
vanzue reviewed Mar 21, 2025
View reviewed changes
src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs Outdated
var version = GetPowerToysVersion();

var gitHubURL = "https://github.com/microsoft/PowerToys/issues/new?template=bug_report.yml&labels=Issue-Bug%2CTriage-Needed" +
"&version=" + version + "&isElevated=" + (IsElevated ? "1" : "2");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see IsElevated as an option in template

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my last commit was unsuccessful. I've updated the code, could you please have another look? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks, do we have following pr for tray icon part?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope in the near future there will be a following PR

@jaimecbernardo
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaimecbernardo
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htcfreek htcfreek htcfreek left review comments

@vanzue vanzue vanzue approved these changes

@shuaiyuanxx shuaiyuanxx shuaiyuanxx approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@donlaci @shuaiyuanxx @vanzue @jaimecbernardo @htcfreek