Add ability to get parameter after set to dond #4759

jenshnielsen · 2022-10-25T07:24:16Z

For some instruments it may be a good idea to get the value after setting it and store that in the dataset rather than relying on the instrument being able to set the exact value.

This implements that by extending the Sweeps classes with a boolean. This could be extended to read a flag from the parameter giving the parameter a trait to indicate if it has been set

This is also a small step towards fixing #4695 since it will become possible to get the value of a parameter that one sets

To make this easier to demonstrate ManualParameters have been improved to log using the instrument logger

TODO

Documentation (examples + docstrings)
Tests
release notes

codecov · 2022-10-25T07:36:43Z

Codecov Report

Merging #4759 (5091f8f) into master (71cb38b) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 5091f8f differs from pull request most recent head a0c6ed1. Consider uploading reports for the commit a0c6ed1 to get more accurate results

@@            Coverage Diff             @@
##           master    #4759      +/-   ##
==========================================
+ Coverage   68.19%   68.23%   +0.04%     
==========================================
  Files         339      339              
  Lines       32019    32017       -2     
==========================================
+ Hits        21835    21847      +12     
+ Misses      10184    10170      -14

astafan8

very very nice idea! and also quite a small change as enabled by the earlier refactor :)

jenshnielsen · 2022-10-28T11:34:59Z

@astafan8 ready for review

astafan8

looks great :)

docs/changes/newsfragments/4759.improved

jenshnielsen · 2022-10-31T09:53:05Z

bors merge

bors · 2022-10-31T09:54:34Z

Canceled.

jenshnielsen · 2022-10-31T10:50:05Z

bors merge

4759: Add ability to get parameter after set to dond r=jenshnielsen a=jenshnielsen For some instruments it may be a good idea to get the value after setting it and store that in the dataset rather than relying on the instrument being able to set the exact value. This implements that by extending the Sweeps classes with a boolean. This could be extended to read a flag from the parameter giving the parameter a trait to indicate if it has been set This is also a small step towards fixing #4695 since it will become possible to get the value of a parameter that one sets To make this easier to demonstrate ManualParameters have been improved to log using the instrument logger TODO - [x] Documentation (examples + docstrings) - [x] Tests - [x] release notes 4770: Add text-wrapping for extra-long plot titles r=jenshnielsen a=samantha-ho This PR text-wraps long plot titles. 4779: Keithley calibration: adjust calibration date before saving new calibration r=astafan8 a=michieldemoor When running the calibrate_keithley_smu_v method to calibrate a Keithley SMU, as documented [here](https://qcodes.github.io/Qcodes/examples/driver_examples/Qcodes%20example%20with%20Keithley%202600.html#Recalibration), the calibration gives the following error: ERROR CODE: 5029 SMU A: Cannot save without changing cal adjustment date SMU B: Cannot save without changing cal adjustment date This PR addresses this error by changing the calibration adjustment date before saving the new calibration. Co-authored-by: Jens H. Nielsen <[email protected]> Co-authored-by: Samantha Ho <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: mdemoor <[email protected]> Co-authored-by: Mikhail Astafev <[email protected]>

bors · 2022-10-31T12:03:48Z

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

jenshnielsen · 2022-10-31T12:31:16Z

bors merge

bors · 2022-10-31T13:30:53Z

This PR was included in a batch that was canceled, it will be automatically retried

4759: Add ability to get parameter after set to dond r=jenshnielsen a=jenshnielsen For some instruments it may be a good idea to get the value after setting it and store that in the dataset rather than relying on the instrument being able to set the exact value. This implements that by extending the Sweeps classes with a boolean. This could be extended to read a flag from the parameter giving the parameter a trait to indicate if it has been set This is also a small step towards fixing #4695 since it will become possible to get the value of a parameter that one sets To make this easier to demonstrate ManualParameters have been improved to log using the instrument logger TODO - [x] Documentation (examples + docstrings) - [x] Tests - [x] release notes 4779: Keithley calibration: adjust calibration date before saving new calibration r=jenshnielsen a=michieldemoor When running the calibrate_keithley_smu_v method to calibrate a Keithley SMU, as documented [here](https://qcodes.github.io/Qcodes/examples/driver_examples/Qcodes%20example%20with%20Keithley%202600.html#Recalibration), the calibration gives the following error: ERROR CODE: 5029 SMU A: Cannot save without changing cal adjustment date SMU B: Cannot save without changing cal adjustment date This PR addresses this error by changing the calibration adjustment date before saving the new calibration. Co-authored-by: Jens H. Nielsen <[email protected]> Co-authored-by: mdemoor <[email protected]> Co-authored-by: Mikhail Astafev <[email protected]>

jenshnielsen · 2022-10-31T13:34:34Z

bors cancel

bors · 2022-10-31T13:34:35Z

Canceled.

jenshnielsen marked this pull request as draft October 25, 2022 07:24

jenshnielsen force-pushed the get_before_set branch from 48aa67d to 31a52ec Compare October 25, 2022 07:24

astafan8 reviewed Oct 25, 2022

View reviewed changes

jenshnielsen force-pushed the get_before_set branch from 31a52ec to f22e385 Compare October 28, 2022 08:28

jenshnielsen marked this pull request as ready for review October 28, 2022 11:34

jenshnielsen force-pushed the get_before_set branch from 07dbccf to bc7e87c Compare October 28, 2022 11:34

jenshnielsen changed the title ~~[wip] Add ability to get parameter after set to dond~~ Add ability to get parameter after set to dond Oct 28, 2022

astafan8 approved these changes Oct 31, 2022

View reviewed changes

docs/changes/newsfragments/4759.improved Show resolved Hide resolved

jenshnielsen force-pushed the get_before_set branch from f57eadb to 86812a5 Compare October 31, 2022 14:21

jenshnielsen added 8 commits October 31, 2022 16:21

Add ability to get parameter after set to dond

0609905

add basic test of get after set working correctly

7c76c7f

document get_after_set

e6047c9

ensure that manual parameters use the instrument logger if avilable

e933ba9

extend dond example notebooks with get_after_set

a56ee38

add test that get_after_set stores gotten data

a9b8b11

add changes fro 4759

b156d45

add explicit type for instrument.log to help mypy

cf8205c

jenshnielsen added 2 commits October 31, 2022 16:21

add type to mylogger

8b106f4

add note about what we store

a0c6ed1

jenshnielsen force-pushed the get_before_set branch from 86812a5 to a0c6ed1 Compare October 31, 2022 15:21

jenshnielsen enabled auto-merge October 31, 2022 15:21

jenshnielsen merged commit 7489a75 into microsoft:master Oct 31, 2022

jenshnielsen deleted the get_before_set branch November 1, 2022 08:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to get parameter after set to dond #4759

Add ability to get parameter after set to dond #4759

jenshnielsen commented Oct 25, 2022 •

edited

Loading

codecov bot commented Oct 25, 2022 •

edited

Loading

astafan8 left a comment

jenshnielsen commented Oct 28, 2022

astafan8 left a comment

jenshnielsen commented Oct 31, 2022

bors bot commented Oct 31, 2022

jenshnielsen commented Oct 31, 2022

bors bot commented Oct 31, 2022

jenshnielsen commented Oct 31, 2022

bors bot commented Oct 31, 2022

jenshnielsen commented Oct 31, 2022

bors bot commented Oct 31, 2022

Add ability to get parameter after set to dond #4759

Add ability to get parameter after set to dond #4759

Conversation

jenshnielsen commented Oct 25, 2022 • edited Loading

codecov bot commented Oct 25, 2022 • edited Loading

Codecov Report

astafan8 left a comment

Choose a reason for hiding this comment

jenshnielsen commented Oct 28, 2022

astafan8 left a comment

Choose a reason for hiding this comment

jenshnielsen commented Oct 31, 2022

bors bot commented Oct 31, 2022

jenshnielsen commented Oct 31, 2022

bors bot commented Oct 31, 2022

jenshnielsen commented Oct 31, 2022

bors bot commented Oct 31, 2022

jenshnielsen commented Oct 31, 2022

bors bot commented Oct 31, 2022

jenshnielsen commented Oct 25, 2022 •

edited

Loading

codecov bot commented Oct 25, 2022 •

edited

Loading