-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Devikamehra/improve error join measurement #453
Devikamehra/improve error join measurement #453
Conversation
…oft#424) This change is part of microsoft#190.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good start!
I'd take this change one step further and add the same level of details that Measurements kata offers: Misclassified |1⟩ as |0⟩ in 52 test runs.
(having the string representations of the states misclassified, and the ability to report how many times each state was misclassified as one or another error) - it is a lot easier for the learner to troubleshoot the states without being exposed to the internal indices we use to mark them. You'd have to pass the string representations as a String[]
array as an argument, and to track a 2-dimensional array of errors (written is a 1-dimensional for convenience).
Thank you!
…hub.com/devikamehra/QuantumKatas into devikamehra/ImproveErrorJoinMeasurement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a pass and left some comments - I think I found the cause of CI build break, so once you fix those, it should work.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I reverted part of the change that reintroduced deprecated functions RandomInt and RandomReal - they've been deprecated in the most recent QDK release and removed in ebc0ce0 - and some whitespace changes - those were all minor and didn't warrant another review iteration.
Thank you!
#176 Improved error statements in Joint Measurement Kata.