Merge pull request #312 from microsoft/dev

ensure names are unique

src/TeamCloud.API/Controllers/DeploymentScopesController.cs

@@ -95,6 +95,15 @@ public Task<IActionResult> Post([FromBody] DeploymentScopeDefinition deploymentS
                .BadRequest(definitionValidationResult)
                .ToActionResult();
 
+       var nameExists = await deploymentScopeRepository
+            .NameExistsAsync(organization.Id, deploymentScopeDefinition.Slug)
+            .ConfigureAwait(false);
+
+       if (nameExists)
+           return ErrorResult
+               .Conflict($"A Deployment Scope with name '{deploymentScopeDefinition.DisplayName}' already exists. Deployment Scope names must be unique. Please try your request again with a unique name.")
+               .ToActionResult();
+
        var deploymentScope = new DeploymentScope
        {
            Id = Guid.NewGuid().ToString(),

src/TeamCloud.API/Controllers/OrganizationsController.cs

@@ -102,16 +102,16 @@ public async Task<IActionResult> Post([FromBody] OrganizationDefinition organiza
                 .BadRequest(validationResult)
                 .ToActionResult();
 
-        var organization = await organizationRepository
-            .GetAsync(UserService.CurrentUserTenant, organizationDefinition.Slug)
+        var nameExists = await organizationRepository
+            .NameExistsAsync(UserService.CurrentUserTenant, organizationDefinition.Slug)
             .ConfigureAwait(false);
 
-        if (organization is not null)
+        if (nameExists)
             return ErrorResult
                 .Conflict($"The Organication '{organizationDefinition.Slug}' already exists. Please try your request again with a unique Organization Name or Id.")
                 .ToActionResult();
 
-        organization = new Organization
+        var organization = new Organization
         {
             Id = Guid.NewGuid().ToString(),
             Tenant = UserService.CurrentUserTenant,

src/TeamCloud.API/Controllers/ProjectController.cs

@@ -131,7 +131,7 @@ public Task<IActionResult> Post([FromBody] ProjectDefinition projectDefinition)
                 .ToActionResult();
 
         var nameExists = await projectRepository
-            .NameExistsAsync(organization.Id, projectDefinition.DisplayName)
+            .NameExistsAsync(organization.Id, projectDefinition.Slug)
             .ConfigureAwait(false);
 
         if (nameExists)

src/TeamCloud.Data/CosmosDb/CosmosDbDeploymentScopeRepository.cs

@@ -56,6 +56,14 @@ private void RemoveCachedIds(DeploymentScope deploymentScope)
         cache.Remove($"{deploymentScope.Organization}_{deploymentScope.Id}");
     }
 
+    public async Task<bool> NameExistsAsync(string organization, string name)
+    {
+        var project = await ResolveIdAsync(organization, name)
+            .ConfigureAwait(false);
+
+        return project is not null;
+    }
+
     public override async Task<DeploymentScope> AddAsync(DeploymentScope deploymentScope)
     {
         if (deploymentScope is null)

src/TeamCloud.Data/CosmosDb/CosmosDbOrganizationRepository.cs

@@ -50,6 +50,14 @@ public async Task<string> ResolveIdAsync(string tenant, string identifier)
         return id;
     }
 
+    public async Task<bool> NameExistsAsync(string organization, string name)
+    {
+        var project = await ResolveIdAsync(organization, name)
+            .ConfigureAwait(false);
+
+        return project is not null;
+    }
+
     public override async Task<Organization> AddAsync(Organization organization)
     {
         if (organization is null)

src/TeamCloud.Data/IDeploymentScopeRepository.cs

@@ -10,6 +10,9 @@ namespace TeamCloud.Data;
 
 public interface IDeploymentScopeRepository : IDocumentRepository<DeploymentScope>
 {
-    Task<string> ResolveIdAsync(string tenant, string identifier);
+    Task<bool> NameExistsAsync(string organization, string name);
+
+    Task<string> ResolveIdAsync(string organization, string identifier);
+
     Task<DeploymentScope> GetDefaultAsync(string organization);
 }

src/TeamCloud.Data/IOrganizationRepository.cs

@@ -11,6 +11,8 @@ namespace TeamCloud.Data;
 
 public interface IOrganizationRepository : IDocumentRepository<Organization>
 {
+    Task<bool> NameExistsAsync(string organization, string name);
+
     Task<string> ResolveIdAsync(string tenant, string identifier);
 
     IAsyncEnumerable<Organization> ListAsync(string tenant, IEnumerable<string> identifiers);

src/TeamCloud.Data/IProjectTemplateRepository.cs

@@ -10,5 +10,7 @@ namespace TeamCloud.Data;
 
 public interface IProjectTemplateRepository : IDocumentRepository<ProjectTemplate>
 {
+    // Task<bool> NameExistsAsync(string organization, string name);
+
     Task<ProjectTemplate> GetDefaultAsync(string organization);
 }

src/TeamCloud.Model/Data/Component.cs

@@ -50,6 +50,7 @@ public sealed class Component : ContainerDocument, ISoftDelete, IProjectContext,
     /// <summary>
     /// Gets or sets the component's display name.
     /// </summary>
+    [UniqueKey]
     public string DisplayName { get; set; }
 
     /// <summary>

src/TeamCloud.Model/Data/DeploymentScope.cs

@@ -20,6 +20,7 @@ public sealed class DeploymentScope : ContainerDocument, IOrganizationContext, I
     [JsonProperty(Required = Required.Always)]
     public string Organization { get; set; }
 
+    [UniqueKey]
     [JsonProperty(Required = Required.Always)]
     public string DisplayName { get; set; }
 

src/TeamCloud.Model/Data/Organization.cs

@@ -30,6 +30,7 @@ public string Slug
         set => slug = value;
     }
 
+    [UniqueKey]
     [JsonProperty(Required = Required.Always)]
     public string DisplayName { get; set; }
 

src/TeamCloud.Model/Data/ProjectTemplate.cs

@@ -31,6 +31,7 @@ public string Slug
 
     public string Name { get; set; }
 
+    [UniqueKey]
     [JsonProperty(Required = Required.Always)]
     public string DisplayName { get; set; }