Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python housekeeping #188

Merged
merged 13 commits into from
Feb 23, 2024
Merged

Python housekeeping #188

merged 13 commits into from
Feb 23, 2024

Conversation

DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Feb 22, 2024

This PR makes the following changes

  • Further readies the repository for the upcoming release.
    • Set version to 0.0.2 (0.0.1 is already out)
    • Update the classifiers list
  • Removes many # type: ignore comments and @no_type_check decorators (apart from the ones in music)
  • Removes all unmasked type errors.
  • Hides the DefaultOpenAIModel class in favor of just exposing create_language_model.
  • Corrects the process_requests function to correctly handle quit and exit input (each line contains a trailing newline)
  • Simplifies the evaluator in the math example.

I didn't spend much time on the music sample - there's a lot of type suppressions there and that probably needs its own PR.

I spent a decent amount of time replumbing the math example - and eventually realized there were a lot of surprising issues. For one, the TS schema translation has errors, and the signatures are translated to Callable<any, number>! That's because Callable isn't supported, and TypeChat doesn't translate tuples yet. On top of that, the reason Pydantic can't deal with JsonProgram is due to the lack of indirection in the union type - something that Python 3.12's type aliases would give us. If we were able to state that the example only works in Python 3.12, I think we could clean it up a lot and get real validation working there.

@DanielRosenwasser DanielRosenwasser merged commit b4e6123 into main Feb 23, 2024
6 checks passed
@DanielRosenwasser DanielRosenwasser deleted the daniel/housekeeping branch February 23, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant