Migrate file system to KDL #2234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
reviewed
Nov 4, 2025
inputfiles/patches/file-system.kdl
Outdated
| property kind readonly=#true overrideType="\"directory\"" | ||
| } | ||
|
|
||
| interface FileReader { |
There was a problem hiding this comment.
FileReader is part of the more traditional File API, not the new File System. Let's put it in a separate file.
inputfiles/patches/file-system.kdl
Outdated
| event error type=ProgressEvent | ||
| event loadend type=ProgressEvent | ||
|
|
||
| property readyState overrideType="typeof FileReader.EMPTY | typeof FileReader.LOADING | typeof FileReader.DONE" |
There was a problem hiding this comment.
Should we make this 0 | 1 | 2 while we are at it?
|
I have updated it @saschanaz |
saschanaz
reviewed
Nov 4, 2025
| event load type=ProgressEvent | ||
| event abort type=ProgressEvent | ||
| event error type=ProgressEvent | ||
| event loadend type=ProgressEvent |
There was a problem hiding this comment.
I have a mixed feeling of event types not being in events.kdl, but I guess this is fine.
jakebailey
approved these changes
Nov 4, 2025
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2053