Migrate CSSFontFaceRule and CSSStyleProperties #2238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
reviewed
Nov 5, 2025
inputfiles/patches/cssom.kdl
Outdated
| // anyone as of 2024-10. | ||
| property webkitLineClamp deprecated=#false | ||
|
|
||
| property cssFloat mdnUrl="https://developer.mozilla.org/docs/Web/API/CSSStyleDeclaration/cssFloat" |
There was a problem hiding this comment.
Do we lose MDN URL if we skip this one? We have https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleProperties/cssFloat so hopefully not?
inputfiles/patches/cssom.kdl
Outdated
|
|
||
| interface CSSStyleProperties replaceReference=CSSStyleDeclaration | ||
| interface CSSStyleProperties replaceReference=CSSStyleDeclaration { | ||
| property imageOrientation deprecated=#true |
There was a problem hiding this comment.
We should probably skip this one. I did this for some reason in 0506730 without a comment (this is why every patch should ideally have a comment 🥹, but presumably it was because of w3c/csswg-drafts@600fd75). But in 2025 all browsers have it and I don't think anyone would unship this.
|
Done @saschanaz |
|
Anything left here @saschanaz |
saschanaz
reviewed
Nov 6, 2025
saschanaz
reviewed
Nov 6, 2025
|
LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
jakebailey
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2053