added subpath support to ata #3466
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
@microsoft-github-policy-service agree |
jakebailey
requested changes
Dec 1, 2025
packages/ata/package-lock.json
Outdated
Member
There was a problem hiding this comment.
This file should not be here, this repo uses pnpm.
| }, | ||
| "peerDependencies": { | ||
| "typescript": ">=4.4.4" | ||
| "typescript": "^5.9.3" |
Author
There was a problem hiding this comment.
This is changed because it gives type error to new projects using new typescript versions. See setupTypeAcquision() in the added screenshots. Should I revert it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ata didn't work for importing packages under a subpath. This requests fixes it. And Typescript is updated to latest.
Before
Now
Before
Now