Use `...args: never` in builtin conditional type helpers #55714

Andarist · 2023-09-11T19:08:40Z

closes #55667 , cc @andrewbranch
fixes #56919

typescript-bot · 2023-09-11T19:08:45Z

The TypeScript team hasn't accepted the linked issue #55667. If you can get it accepted, this PR will have a better chance of being reviewed.

jakebailey · 2023-09-11T19:17:11Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-09-11T19:17:14Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 0a2d583. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-11T19:17:14Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 0a2d583. You can monitor the build here.

typescript-bot · 2023-09-11T19:17:14Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 0a2d583. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-11T19:17:14Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 0a2d583. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-11T19:17:14Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 0a2d583. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-11T19:18:59Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/157631/artifacts?artifactName=tgz&fileId=FE94CA1F17108FBA50E4F137461CB62A7EF9321D897F7A94C861969DCFCB26C502&fileName=/typescript-5.3.0-insiders.20230911.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2023-09-11T19:36:11Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55714/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-09-11T19:43:19Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,284k (± 0.00%)}	_{300,289k (± 0.01%)}	_~	_300,264k	_300,307k	_{p=0.630 n=6}
_{Parse Time}	_{3.01s (± 0.17%)}	_{3.00s (± 0.25%)}	_~	_2.99s	_3.01s	_{p=0.247 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{9.32s (± 0.16%)}	_{9.33s (± 0.42%)}	_~	_9.31s	_9.41s	_{p=0.933 n=6}
_{Emit Time}	_{7.63s (± 0.21%)}	_{7.63s (± 0.23%)}	_~	_7.60s	_7.65s	_{p=0.934 n=6}
_{Total Time}	_{20.89s (± 0.10%)}	_{20.89s (± 0.22%)}	_~	_20.85s	_20.98s	_{p=1.000 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,884k (± 0.02%)}	_{193,944k (± 0.01%)}	_{+61k (+ 0.03%)}	_193,917k	_193,992k	_{p=0.031 n=6}
_{Parse Time}	_{1.58s (± 0.00%)}	_{1.58s (± 0.26%)}	_~	_1.57s	_1.58s	_{p=0.405 n=6}
_{Bind Time}	_{0.79s (± 0.69%)}	_{0.80s (± 0.69%)}	_~	_0.79s	_0.80s	_{p=1.000 n=6}
_{Check Time}	_{9.92s (± 0.49%)}	_{9.93s (± 0.29%)}	_~	_9.90s	_9.97s	_{p=0.808 n=6}
_{Emit Time}	_{2.74s (± 0.00%)}	_{2.74s (± 0.19%)}	_~	_2.73s	_2.74s	_{p=0.174 n=6}
_{Total Time}	_{15.03s (± 0.34%)}	_{15.04s (± 0.23%)}	_~	_15.00s	_15.09s	_{p=0.747 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,189k (± 0.01%)}	_{347,189k (± 0.01%)}	_~	_347,145k	_347,212k	_{p=0.936 n=6}
_{Parse Time}	_{2.69s (± 0.39%)}	_{2.69s (± 0.23%)}	_~	_2.68s	_2.70s	_{p=0.388 n=6}
_{Bind Time}	_{0.99s (± 0.00%)}	_{0.99s (± 0.00%)}	_~	_0.99s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{7.92s (± 0.42%)}	_{7.93s (± 0.34%)}	_~	_7.90s	_7.97s	_{p=0.375 n=6}
_{Emit Time}	_{4.26s (± 0.32%)}	_{4.26s (± 0.27%)}	_~	_4.25s	_4.28s	_{p=0.506 n=6}
_{Total Time}	_{15.85s (± 0.26%)}	_{15.88s (± 0.25%)}	_~	_15.82s	_15.93s	_{p=0.297 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,181k (± 0.00%)}	_{301,182k (± 0.01%)}	_~	_301,144k	_301,196k	_{p=0.689 n=6}
_{Parse Time}	_{2.18s (± 0.19%)}	_{2.18s (± 0.73%)}	_~	_2.15s	_2.19s	_{p=0.930 n=6}
_{Bind Time}	_{1.11s (± 0.00%)}	_{1.11s (± 0.37%)}	_~	_1.11s	_1.12s	_{p=0.405 n=6}
_{Check Time}	_{7.24s (± 0.32%)}	_{7.23s (± 0.22%)}	_~	_7.20s	_7.24s	_{p=0.621 n=6}
_{Emit Time}	_{3.99s (± 0.16%)}	_{3.98s (± 0.52%)}	_~	_3.96s	_4.02s	_{p=0.210 n=6}
_{Total Time}	_{14.52s (± 0.15%)}	_{14.51s (± 0.19%)}	_~	_14.46s	_14.54s	_{p=0.685 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,476k (± 0.00%)}	_{479,482k (± 0.00%)}	_~	_479,470k	_479,494k	_{p=0.226 n=6}
_{Parse Time}	_{3.14s (± 0.13%)}	_{3.15s (± 0.24%)}	_~	_3.14s	_3.16s	_{p=0.100 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{0.91s (± 0.00%)}	_~	_0.91s	_0.91s	_{p=1.000 n=6}
_{Check Time}	_{17.83s (± 0.39%)}	_{17.81s (± 0.39%)}	_~	_17.72s	_17.91s	_{p=0.747 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.88s (± 0.32%)}	_{21.88s (± 0.31%)}	_~	_21.78s	_21.97s	_{p=1.000 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,874k (± 0.01%)}	_{542,826k (± 0.01%)}	_~	_542,777k	_542,919k	_{p=0.378 n=6}
_{Parse Time}	_{3.69s (± 0.20%)}	_{3.69s (± 0.20%)}	_~	_3.68s	_3.70s	_{p=0.487 n=6}
_{Bind Time}	_{1.42s (± 4.28%)}	_{1.40s (± 4.69%)}	_~	_1.34s	_1.46s	_{p=0.859 n=6}
_{Check Time}	_{3.21s (± 3.02%)}	_{3.25s (± 2.27%)}	_~	_3.15s	_3.32s	_{p=0.374 n=6}
_{Emit Time}	_{0.09s (± 6.44%)}	_{0.09s (± 6.44%)}	_~	_0.08s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.41s (± 0.50%)}	_{8.42s (± 0.28%)}	_~	_8.38s	_8.45s	_{p=0.332 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,491ms (± 0.12%)}	_{2,491ms (± 0.11%)}	_~	_2,487ms	_2,495ms	_{p=0.809 n=6}
_{Req 2 - geterr}	_{5,924ms (± 0.18%)}	_{5,929ms (± 0.10%)}	_~	_5,922ms	_5,936ms	_{p=0.872 n=6}
_{Req 3 - references}	_{343ms (± 0.34%)}	_{343ms (± 0.22%)}	_~	_342ms	_344ms	_{p=0.796 n=6}
_{Req 4 - navto}	_{275ms (± 0.19%)}	_{275ms (± 0.19%)}	_~	_275ms	_276ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 8.15%)}	_{78ms (± 3.19%)}	_~	_76ms	_81ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,625ms (± 0.60%)}	_{2,616ms (± 0.46%)}	_~	_2,602ms	_2,638ms	_{p=0.574 n=6}
_{Req 2 - geterr}	_{4,770ms (± 0.12%)}	_{4,770ms (± 0.29%)}	_~	_4,757ms	_4,791ms	_{p=0.873 n=6}
_{Req 3 - references}	_{350ms (± 0.21%)}	_{351ms (± 0.35%)}	_~	_349ms	_352ms	_{p=0.502 n=6}
_{Req 4 - navto}	_{268ms (± 0.65%)}	_{269ms (± 0.51%)}	_~	_267ms	_270ms	_{p=0.801 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 3.67%)}	_{77ms (± 3.89%)}	_~	_73ms	_79ms	_{p=0.445 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,702ms (± 0.24%)}	_{2,706ms (± 0.10%)}	_~	_2,704ms	_2,711ms	_{p=0.090 n=6}
_{Req 2 - geterr}	_{1,962ms (± 1.84%)}	_{1,968ms (± 0.91%)}	_~	_1,936ms	_1,982ms	_{p=0.810 n=6}
_{Req 3 - references}	_{140ms (± 1.34%)}	_{141ms (± 0.63%)}	_~	_140ms	_142ms	_{p=0.114 n=6}
_{Req 4 - navto}	_{361ms (± 1.09%)}	_{362ms (± 0.81%)}	_~	_358ms	_365ms	_{p=0.460 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{323ms (± 1.57%)}	_{325ms (± 0.23%)}	_~	_324ms	_326ms	_{p=0.672 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

CompilerTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
xstateTSServer - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{156.90ms (± 0.20%)}	_{156.96ms (± 0.19%)}	_~	_155.01ms	_160.58ms	_{p=0.579 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{230.80ms (± 0.82%)}	_{230.95ms (± 0.13%)}	_{+0.16ms (+ 0.07%)}	_229.11ms	_234.64ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.46ms (± 0.11%)}	_{235.82ms (± 0.13%)}	_{+0.36ms (+ 0.15%)}	_234.56ms	_242.00ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.61ms (± 0.11%)}	_{235.42ms (± 0.13%)}	_{-0.18ms (- 0.08%)}	_234.20ms	_240.82ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

DanielRosenwasser · 2023-09-11T21:10:48Z

Why not InstanceType?

typescript-bot · 2023-09-11T21:14:28Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55714/merge:

Something interesting changed - please have a look.

Details

vuetifyjs/vuetify

4 of 7 projects failed to build with the old tsc and were ignored

packages/vuetify/tsconfig.checks.json

error TS2559: Type '{ [x: string]: any; } & { [x: number]: any; [x: symbol]: any; } & { 'onUpdate:modelValue': ((val: any) => void) | undefined; }' has no properties in common with type 'DensityProps'.
- packages/vuetify/src/components/VSelectionControl/VSelectionControl.tsx#L75

packages/vuetify/tsconfig.dist.json

error TS2559: Type '{ [x: string]: any; } & { [x: number]: any; [x: symbol]: any; } & { 'onUpdate:modelValue': ((val: any) => void) | undefined; }' has no properties in common with type 'DensityProps'.
- packages/vuetify/src/components/VSelectionControl/VSelectionControl.tsx#L75

packages/vuetify/tsconfig.json

error TS2559: Type '{ [x: string]: any; } & { [x: number]: any; [x: symbol]: any; } & { 'onUpdate:modelValue': ((val: any) => void) | undefined; }' has no properties in common with type 'DensityProps'.
- packages/vuetify/src/components/VSelectionControl/VSelectionControl.tsx#L75

src/lib/es5.d.ts

Andarist · 2023-09-11T21:29:49Z

I missed the InstanceType with my multi-cursor edit :v thanks for catching that.

typescript-bot · 2023-09-11T21:30:36Z

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

andrewbranch · 2023-09-11T21:32:39Z

@typescript-bot user test this
@typescript-bot test top200

typescript-bot · 2023-09-11T21:32:42Z

Heya @andrewbranch, I've started to run the diff-based user code test suite on this PR at e08f2a3. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-11T21:32:42Z

Heya @andrewbranch, I've started to run the diff-based top-repos suite on this PR at e08f2a3. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-11T21:50:37Z

@andrewbranch Here are the results of running the user test suite comparing main and refs/pull/55714/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-09-11T23:33:20Z

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/55714/merge:

Something interesting changed - please have a look.

Details

vuetifyjs/vuetify

4 of 7 projects failed to build with the old tsc and were ignored

packages/vuetify/tsconfig.checks.json

error TS2559: Type '{ [x: string]: any; } & { [x: number]: any; [x: symbol]: any; } & { 'onUpdate:modelValue': ((val: any) => void) | undefined; }' has no properties in common with type 'DensityProps'.
- packages/vuetify/src/components/VSelectionControl/VSelectionControl.tsx#L75

packages/vuetify/tsconfig.dist.json

error TS2559: Type '{ [x: string]: any; } & { [x: number]: any; [x: symbol]: any; } & { 'onUpdate:modelValue': ((val: any) => void) | undefined; }' has no properties in common with type 'DensityProps'.
- packages/vuetify/src/components/VSelectionControl/VSelectionControl.tsx#L75

packages/vuetify/tsconfig.json

error TS2559: Type '{ [x: string]: any; } & { [x: number]: any; [x: symbol]: any; } & { 'onUpdate:modelValue': ((val: any) => void) | undefined; }' has no properties in common with type 'DensityProps'.
- packages/vuetify/src/components/VSelectionControl/VSelectionControl.tsx#L75

Andarist · 2023-09-12T07:27:21Z

Extracted (not exactly minimal yet) repro from vuetify: TS playground

andrewbranch · 2023-09-12T15:57:16Z

That’s... weird

jfet97 · 2023-09-21T20:04:10Z

Here is a 17 loc repro.

andrewbranch · 2023-09-22T17:09:13Z

I think this is exposing an inference/assignability bug, not a logical consequence of switching the parameter type in the conditional extends type. I notice that if you swap infer R in NewReturnType for any or unknown, T1 starts taking the true branch of the conditional. So it seems like infer R is making the input type fail the extends assignability check, not ...args: never. That will need to be fixed first or as part of this PR.

jfet97 · 2023-09-24T15:28:12Z

@andrewbranch I'll tell you what I found out after some debugging of the code in this playground.

Inside getConditionalType, when we are applying the two versions of the conditional to <D extends Record<string, unknown>>(t: D) => Foo<D> we have:

With the classic definition of ReturnType:
With the modified defition, the one that uses never as the argument's type:

In both cases R is correctly inferred as Foo<Record<string, unknown>>, but what is failing is the isTypeAssignableTo check between checkType and inferredExtendsType. What is that check for?

Return falseType for a definitely false extends check. We check an instantiations of the two types with type parameters mapped to the wildcard type, the most permissive instantiations possible (the wildcard type is assignable to and from all types). If those are not related, then no instantiations will be and we can just return the false branch type.

This is exactly what happens, because the never version always returns what is present in the false branch in this specific playground.

So when compareSignaturesRelated comes into play because of isTypeAssignableTo we have:

any version:
1.1 source is <D extends Record<string, unknown>>(t: D): Foo<D>
1.2 target is (...args: any): Foo<Record<string, unknown>>
1.3 source becomes (t: any): Foo<any> because of instantiateSignatureInContextOf
1.4 So it seems all fine and dandy :)
never version:
2.1 source is <D extends Record<string, unknown>>(t: D): Foo<D>
2.2 target is (...args: never): Foo<Record<string, unknown>>
2.3 source becomes (t: never): Foo<never> because of instantiateSignatureInContextOf
2.4 When params are checked sourceType = [t: never] and targetType = never are compared and found related. OTOH Foo<never> and Foo<Record<string, unknown>>, the two return types, are not considered related because D, the parameter of Foo, is an invariant type parameter (even if actually they are the same type considering how Foo is defined)

I suppose that the source of the problem is instantiateSignatureInContextOf that produces the Foo<never> as return type for source instead of what we would need, that is R i.e. Record<string, unknown>. Another supposition: this problem has never come up with the usual ReturnType definition because instantiateSignatureInContextOf in that case uses any, that has more chances to be considered related to other types.

andrewbranch

Marking this as not currently mergeable based on my previous comment

Andarist · 2023-11-13T22:31:50Z

I plan to get back to this soon-ish but I have a backlog of PR reviews to address right now so it will take some time 😉

…helpers

Andarist · 2024-01-01T20:04:22Z

@jakebailey @andrewbranch could you rerun test suite here? :)

andrewbranch · 2024-01-02T20:03:46Z

@typescript-bot user test this
@typescript-bot test top200

typescript-bot · 2024-01-02T20:03:49Z

Heya @andrewbranch, I've started to run the diff-based top-repos suite on this PR at f06aaaa. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-02T20:03:49Z

Heya @andrewbranch, I've started to run the diff-based user code test suite on this PR at f06aaaa. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-02T20:22:34Z

@andrewbranch Here are the results of running the user test suite comparing main and refs/pull/55714/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L23 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-01-02T21:39:29Z

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/55714/merge:

Everything looks good!

jfet97 · 2024-01-08T18:08:35Z

Hi @andrewbranch , do you think this PR can now become part of TS 5.4? The assignability problem has been solved by changing the definitions again (arguments/return type are being inferred even when not needed, then discarded), and there are no more failed tests.

andrewbranch · 2024-01-08T21:39:31Z

Why are the infer _ needed?

jfet97 · 2024-01-08T21:42:12Z

Why are the infer _ needed?

#56919 and this comment explain what happens if you don't use it.

andrewbranch · 2024-01-09T00:10:33Z

@typescript-bot perf test

typescript-bot · 2024-01-09T00:10:37Z

Heya @andrewbranch, I've started to run the regular perf test suite on this PR at f06aaaa. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-09T00:30:11Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{154.38ms (± 0.20%)}	_{154.34ms (± 0.18%)}	_~	_153.10ms	_156.93ms	_{p=0.527 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.28ms (± 0.16%)}	_{228.99ms (± 0.17%)}	_{-0.29ms (- 0.13%)}	_227.72ms	_234.25ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.87ms (± 0.18%)}	_{230.88ms (± 0.20%)}	_~	_228.87ms	_236.94ms	_{p=0.809 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.64ms (± 0.19%)}	_{230.68ms (± 0.20%)}	_~	_228.91ms	_237.87ms	_{p=0.751 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,472k (± 0.01%)}	_{295,491k (± 0.01%)}	_~	_295,425k	_295,518k	_{p=0.230 n=6}
_{Parse Time}	_{2.65s (± 0.28%)}	_{2.65s (± 0.19%)}	_~	_2.65s	_2.66s	_{p=0.784 n=6}
_{Bind Time}	_{0.82s (± 0.00%)}	_{0.82s (± 0.00%)}	_~	_0.82s	_0.82s	_{p=1.000 n=6}
_{Check Time}	_{8.15s (± 0.32%)}	_{8.16s (± 0.22%)}	_~	_8.14s	_8.19s	_{p=0.805 n=6}
_{Emit Time}	_{7.09s (± 0.19%)}	_{7.09s (± 0.30%)}	_~	_7.07s	_7.12s	_{p=0.625 n=6}
_{Total Time}	_{18.72s (± 0.15%)}	_{18.72s (± 0.11%)}	_~	_18.69s	_18.74s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,502k (± 1.23%)}	_{191,519k (± 0.03%)}	_~	_191,460k	_191,569k	_{p=0.470 n=6}
_{Parse Time}	_{1.34s (± 0.62%)}	_{1.35s (± 0.81%)}	_~	_1.34s	_1.37s	_{p=0.652 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.26s (± 0.42%)}	_{9.30s (± 0.29%)}	_~	_9.26s	_9.33s	_{p=0.108 n=6}
_{Emit Time}	_{2.63s (± 0.62%)}	_{2.61s (± 0.62%)}	_~	_2.59s	_2.64s	_{p=0.211 n=6}
_{Total Time}	_{13.96s (± 0.36%)}	_{13.98s (± 0.29%)}	_~	_13.91s	_14.02s	_{p=0.468 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,408k (± 0.01%)}	_{347,419k (± 0.01%)}	_~	_347,379k	_347,433k	_{p=0.378 n=6}
_{Parse Time}	_{2.46s (± 0.49%)}	_{2.46s (± 0.31%)}	_~	_2.45s	_2.47s	_{p=0.867 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.93s (± 0.88%)}	_~	_0.92s	_0.94s	_{p=0.929 n=6}
_{Check Time}	_{6.88s (± 0.43%)}	_{6.88s (± 0.18%)}	_~	_6.87s	_6.90s	_{p=0.459 n=6}
_{Emit Time}	_{4.05s (± 0.29%)}	_{4.06s (± 0.55%)}	_~	_4.02s	_4.08s	_{p=0.739 n=6}
_{Total Time}	_{14.31s (± 0.33%)}	_{14.33s (± 0.13%)}	_~	_14.30s	_14.35s	_{p=0.871 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,744k (± 0.00%)}	_{302,732k (± 0.00%)}	_~	_302,709k	_302,746k	_{p=0.093 n=6}
_{Parse Time}	_{2.00s (± 0.86%)}	_{1.99s (± 1.70%)}	_~	_1.95s	_2.03s	_{p=0.936 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.01s (± 1.32%)}	_~	_0.99s	_1.02s	_{p=0.206 n=6}
_{Check Time}	_{6.31s (± 0.28%)}	_{6.32s (± 0.38%)}	_~	_6.28s	_6.34s	_{p=0.459 n=6}
_{Emit Time}	_{3.59s (± 0.18%)}	_{3.59s (± 0.51%)}	_~	_3.56s	_3.61s	_{p=0.655 n=6}
_{Total Time}	_{12.90s (± 0.25%)}	_{12.91s (± 0.26%)}	_~	_12.86s	_12.96s	_{p=0.420 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{506,839k (± 0.00%)}	_{506,941k (± 0.01%)}	_{+102k (+ 0.02%)}	_506,902k	_506,996k	_{p=0.005 n=6}
_{Parse Time}	_{2.58s (± 0.57%)}	_{2.58s (± 0.45%)}	_~	_2.57s	_2.60s	_{p=0.933 n=6}
_{Bind Time}	_{0.98s (± 0.85%)}	_{1.00s (± 1.26%)}	_{+0.02s (+ 1.52%)}	_0.99s	_1.02s	_{p=0.040 n=6}
_{Check Time}	_{16.91s (± 0.33%)}	_{17.01s (± 0.79%)}	_~	_16.85s	_17.17s	_{p=0.199 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.47s (± 0.30%)}	_{20.59s (± 0.71%)}	_~	_20.41s	_20.77s	_{p=0.173 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,919k (± 0.02%)}	_{512,909k (± 0.01%)}	_~	_512,818k	_512,966k	_{p=0.575 n=6}
_{Parse Time}	_{3.28s (± 0.19%)}	_{3.28s (± 0.31%)}	_~	_3.26s	_3.29s	_{p=0.654 n=6}
_{Bind Time}	_{1.54s (± 0.49%)}	_{1.54s (± 0.34%)}	_~	_1.53s	_1.54s	_{p=0.784 n=6}
_{Check Time}	_{2.82s (± 0.48%)}	_{2.83s (± 0.72%)}	_~	_2.81s	_2.87s	_{p=0.618 n=6}
_{Emit Time}	_{0.07s (± 5.69%)}	_{0.07s (± 0.00%)}	_~	_0.07s	_0.07s	_{p=0.405 n=6}
_{Total Time}	_{7.72s (± 0.22%)}	_{7.71s (± 0.31%)}	_~	_7.69s	_7.76s	_{p=0.517 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,352ms (± 1.02%)}	_{2,336ms (± 0.49%)}	_~	_2,324ms	_2,352ms	_{p=0.199 n=6}
_{Req 2 - geterr}	_{5,410ms (± 1.21%)}	_{5,437ms (± 1.13%)}	_~	_5,374ms	_5,519ms	_{p=0.173 n=6}
_{Req 3 - references}	_{326ms (± 1.53%)}	_{327ms (± 1.40%)}	_~	_321ms	_332ms	_{p=0.935 n=6}
_{Req 4 - navto}	_{275ms (± 1.12%)}	_{276ms (± 1.27%)}	_~	_271ms	_279ms	_{p=0.669 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{90ms (± 5.80%)}	_{87ms (± 6.13%)}	_~	_83ms	_94ms	_{p=0.287 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,464ms (± 1.05%)}	_{2,468ms (± 0.89%)}	_~	_2,448ms	_2,498ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,160ms (± 1.75%)}	_{4,137ms (± 1.89%)}	_~	_4,079ms	_4,239ms	_{p=0.575 n=6}
_{Req 3 - references}	_{339ms (± 1.28%)}	_{339ms (± 1.29%)}	_~	_333ms	_344ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{285ms (± 1.12%)}	_{286ms (± 0.97%)}	_~	_283ms	_291ms	_{p=0.330 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 6.45%)}	_{84ms (± 6.47%)}	_~	_77ms	_90ms	_{p=0.420 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,620ms (± 0.30%)}	_{2,602ms (± 0.75%)}	_{-18ms (- 0.68%)}	_2,567ms	_2,620ms	_{p=0.045 n=6}
_{Req 2 - geterr}	_{1,741ms (± 1.50%)}	_{1,707ms (± 2.73%)}	_~	_1,664ms	_1,778ms	_{p=0.230 n=6}
_{Req 3 - references}	_{112ms (± 9.97%)}	_{109ms (± 8.30%)}	_~	_102ms	_123ms	_{p=0.935 n=6}
_{Req 4 - navto}	_{366ms (± 0.41%)}	_{366ms (± 0.30%)}	_~	_365ms	_367ms	_{p=0.865 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{311ms (± 1.71%)}	_{305ms (± 2.13%)}	_~	_296ms	_314ms	_{p=0.126 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Use ...args: never in builtin conditional type helpers

0a2d583

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 11, 2023

andrewbranch reviewed Sep 11, 2023

View reviewed changes

src/lib/es5.d.ts Show resolved Hide resolved

Update InstanceType as well

e08f2a3

sandersn assigned andrewbranch Sep 21, 2023

sandersn requested a review from DanielRosenwasser September 21, 2023 22:54

ssalbdivad mentioned this pull request Oct 26, 2023

Narrowing this using custom type predicate affected by TS 5.0 #53436

Open

andrewbranch requested changes Nov 13, 2023

View reviewed changes

jfet97 mentioned this pull request Jan 1, 2024

Counterexample to current ReturnType logic with type parameters #56919

Open

Andarist added 3 commits January 1, 2024 20:18

Merge remote-tracking branch 'origin/main' into top-level-fn-type-in-…

729839b

…helpers

update definitions

4a85dfd

add tests

0a4e49c

Andarist added 2 commits January 1, 2024 23:54

tweak incremental file

b720cec

update baselines

f06aaaa

Andarist requested a review from andrewbranch January 8, 2024 18:14

jfet97 mentioned this pull request Jul 6, 2024

Some long function return expressions no longer evaluated in 5.5 #58937

Closed

Use ...args: never in builtin conditional type helpers #55714

Are you sure you want to change the base?

Use ...args: never in builtin conditional type helpers #55714

Conversation

Andarist commented Sep 11, 2023 • edited Loading

typescript-bot commented Sep 11, 2023

jakebailey commented Sep 11, 2023

typescript-bot commented Sep 11, 2023 • edited Loading

typescript-bot commented Sep 11, 2023 • edited Loading

typescript-bot commented Sep 11, 2023 • edited Loading

typescript-bot commented Sep 11, 2023 • edited Loading

typescript-bot commented Sep 11, 2023 • edited Loading

typescript-bot commented Sep 11, 2023 • edited Loading

typescript-bot commented Sep 11, 2023

typescript-bot commented Sep 11, 2023

Compiler

tsserver

Startup

DanielRosenwasser commented Sep 11, 2023

typescript-bot commented Sep 11, 2023

Andarist commented Sep 11, 2023

typescript-bot commented Sep 11, 2023

andrewbranch commented Sep 11, 2023

typescript-bot commented Sep 11, 2023 • edited Loading

typescript-bot commented Sep 11, 2023 • edited Loading

typescript-bot commented Sep 11, 2023

typescript-bot commented Sep 11, 2023

Andarist commented Sep 12, 2023

andrewbranch commented Sep 12, 2023

jfet97 commented Sep 21, 2023

andrewbranch commented Sep 22, 2023

jfet97 commented Sep 24, 2023 • edited Loading

andrewbranch left a comment

Choose a reason for hiding this comment

Andarist commented Nov 13, 2023

Andarist commented Jan 1, 2024

andrewbranch commented Jan 2, 2024

typescript-bot commented Jan 2, 2024 • edited Loading

typescript-bot commented Jan 2, 2024 • edited Loading

typescript-bot commented Jan 2, 2024

typescript-bot commented Jan 2, 2024

jfet97 commented Jan 8, 2024 • edited Loading

andrewbranch commented Jan 8, 2024

jfet97 commented Jan 8, 2024

andrewbranch commented Jan 9, 2024

typescript-bot commented Jan 9, 2024 • edited Loading

typescript-bot commented Jan 9, 2024

startup

tsc

tsserver

Use `...args: never` in builtin conditional type helpers #55714

Use `...args: never` in builtin conditional type helpers #55714

Andarist commented Sep 11, 2023 •

edited

Loading

typescript-bot commented Sep 11, 2023 •

edited

Loading

typescript-bot commented Sep 11, 2023 •

edited

Loading

typescript-bot commented Sep 11, 2023 •

edited

Loading

typescript-bot commented Sep 11, 2023 •

edited

Loading

typescript-bot commented Sep 11, 2023 •

edited

Loading

typescript-bot commented Sep 11, 2023 •

edited

Loading

typescript-bot commented Sep 11, 2023 •

edited

Loading

typescript-bot commented Sep 11, 2023 •

edited

Loading

jfet97 commented Sep 24, 2023 •

edited

Loading

typescript-bot commented Jan 2, 2024 •

edited

Loading

typescript-bot commented Jan 2, 2024 •

edited

Loading

jfet97 commented Jan 8, 2024 •

edited

Loading

typescript-bot commented Jan 9, 2024 •

edited

Loading