Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement(60881): Added detailed diagnostic for parent to child assignment #61145

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

NamHaiBui
Copy link

@NamHaiBui NamHaiBui commented Feb 7, 2025

Fixes #60881

@NamHaiBui
Copy link
Author

@microsoft-github-policy-service agree

@RolandLocke
Copy link

This newest change will fail the CI tests. However, it should correctly add the message we are looking for. I didn't accept the baseline so we can perform the difference checker in class tomorrow and ensure the new message is correct.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 19, 2025
@NamHaiBui NamHaiBui marked this pull request as ready for review February 19, 2025 02:30
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 19, 2025
@NamHaiBui NamHaiBui changed the title 60881 Implement(60881): Added detailed diagnostic for parent to child assignment Feb 21, 2025
@jakebailey
Copy link
Member

This PR contains a bunch of unrelated formatting changes which make this PR hard to review; you should revert these. If you have auto-format enabled in your editor, make sure it's running dprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Status: Not started
Development

Successfully merging this pull request may close these issues.

misleading error message on invalid assignment when one type parameter extends another
5 participants