Treat functions with `@type` tags on parameters as typed in JS files #61177

Andarist · 2025-02-14T20:11:53Z

fixes #61172

jakebailey · 2025-02-22T00:38:29Z

This feels right, but needs to have main merged into it to run the extended tests.

…ith-type-on-params

Andarist · 2025-02-22T08:26:44Z

@jakebailey conflict resolved

jakebailey · 2025-02-24T18:36:49Z

@typescript-bot test it

typescript-bot · 2025-02-24T18:36:58Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-02-24T18:59:10Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-02-24T18:59:38Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61177/merge:

Everything looks good!

typescript-bot · 2025-02-24T19:21:48Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,383k (± 0.99%)}	_{195,989k (± 0.74%)}	_~	_193,042k	_196,663k	_{p=0.936 n=6}
_{Parse Time}	_{1.58s (± 1.88%)}	_{1.60s (± 0.47%)}	_~	_1.59s	_1.61s	_{p=0.250 n=6}
_{Bind Time}	_{0.88s (± 0.93%)}	_{0.87s (± 1.72%)}	_~	_0.86s	_0.90s	_{p=0.388 n=6}
_{Check Time}	_{11.81s (± 0.77%)}	_{11.80s (± 0.70%)}	_~	_11.70s	_11.94s	_{p=0.936 n=6}
_{Emit Time}	_{3.34s (± 4.02%)}	_{3.33s (± 4.11%)}	_~	_3.23s	_3.60s	_{p=0.687 n=6}
_{Total Time}	_{17.61s (± 1.14%)}	_{17.60s (± 0.84%)}	_~	_17.44s	_17.85s	_{p=0.810 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,300k (± 0.01%)}	_{1,224,312k (± 0.01%)}	_~	_1,224,201k	_1,224,398k	_{p=0.689 n=6}
_{Parse Time}	_{8.06s (± 0.93%)}	_{8.02s (± 0.93%)}	_~	_7.91s	_8.11s	_{p=0.328 n=6}
_{Bind Time}	_{2.28s (± 0.39%)}	_{2.30s (± 0.45%)}	_{+0.02s (+ 0.73%)}	_2.28s	_2.31s	_{p=0.027 n=6}
_{Check Time}	_{37.93s (± 0.64%)}	_{37.91s (± 0.48%)}	_~	_37.71s	_38.19s	_{p=0.936 n=6}
_{Emit Time}	_{18.23s (± 0.49%)}	_{18.35s (± 0.61%)}	_~	_18.25s	_18.53s	_{p=0.090 n=6}
_{Total Time}	_{66.49s (± 0.42%)}	_{66.58s (± 0.26%)}	_~	_66.31s	_66.83s	_{p=0.575 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,346,675	_2,346,675	_~	_~	_~	_{p=1.000 n=6}
_Types	_845,442	_845,442	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,120,582k (± 0.01%)}	_{2,120,426k (± 0.01%)}	_~	_2,120,299k	_2,120,632k	_{p=0.128 n=6}
_{Parse Time}	_{8.80s (± 0.21%)}	_{8.75s (± 0.60%)}	_~	_8.70s	_8.84s	_{p=0.077 n=6}
_{Bind Time}	_{2.92s (± 1.15%)}	_{2.95s (± 0.78%)}	_~	_2.92s	_2.98s	_{p=0.090 n=6}
_{Check Time}	_{87.19s (± 0.44%)}	_{86.95s (± 0.20%)}	_~	_86.74s	_87.22s	_{p=0.173 n=6}
_{Emit Time}	_{0.20s (± 4.95%)}	_{0.20s (± 2.06%)}	_~	_0.19s	_0.20s	_{p=0.930 n=6}
_{Total Time}	_{99.10s (± 0.40%)}	_{98.85s (± 0.20%)}	_~	_98.60s	_99.18s	_{p=0.128 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,588	_1,226,591	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,986	_266,987	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,845,229k (±13.21%)}	_{2,723,606k (±14.65%)}	_~	_2,358,655k	_3,088,789k	_{p=0.575 n=6}
_{Parse Time}	_{6.66s (± 1.44%)}	_{6.62s (± 1.79%)}	_~	_6.47s	_6.80s	_{p=0.423 n=6}
_{Bind Time}	_{2.16s (± 1.46%)}	_{2.18s (± 0.92%)}	_~	_2.15s	_2.20s	_{p=0.226 n=6}
_{Check Time}	_{42.74s (± 0.23%)}	_{42.80s (± 0.47%)}	_~	_42.45s	_43.01s	_{p=0.230 n=6}
_{Emit Time}	_{3.58s (± 4.61%)}	_{3.49s (± 5.09%)}	_~	_3.34s	_3.83s	_{p=0.230 n=6}
_{Total Time}	_{55.14s (± 0.24%)}	_{55.09s (± 0.62%)}	_~	_54.54s	_55.45s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,588	_1,226,591	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,986	_266,987	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,911,416k (±12.85%)}	_{2,911,694k (±12.86%)}	_~	_2,427,623k	_3,154,240k	_{p=1.000 n=6}
_{Parse Time}	_{6.94s (± 2.04%)}	_{6.89s (± 1.70%)}	_~	_6.70s	_7.00s	_{p=0.471 n=6}
_{Bind Time}	_{2.14s (± 0.86%)}	_{2.15s (± 1.30%)}	_~	_2.11s	_2.19s	_{p=0.420 n=6}
_{Check Time}	_{42.83s (± 0.32%)}	_{42.84s (± 0.87%)}	_~	_42.33s	_43.20s	_{p=0.575 n=6}
_{Emit Time}	_{3.49s (± 2.14%)}	_{3.45s (± 1.40%)}	_~	_3.39s	_3.51s	_{p=0.297 n=6}
_{Total Time}	_{55.40s (± 0.54%)}	_{55.34s (± 0.85%)}	_~	_54.71s	_55.79s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,667	_262,670	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,849	_106,850	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{440,415k (± 0.02%)}	_{440,356k (± 0.02%)}	_~	_440,255k	_440,526k	_{p=0.378 n=6}
_{Parse Time}	_{3.54s (± 1.42%)}	_{3.55s (± 1.28%)}	_~	_3.50s	_3.61s	_{p=0.572 n=6}
_{Bind Time}	_{1.31s (± 0.48%)}	_{1.31s (± 0.96%)}	_~	_1.30s	_1.33s	_{p=0.799 n=6}
_{Check Time}	_{18.89s (± 0.30%)}	_{18.92s (± 0.56%)}	_~	_18.81s	_19.09s	_{p=0.873 n=6}
_{Emit Time}	_{1.52s (± 1.35%)}	_{1.51s (± 0.99%)}	_~	_1.50s	_1.54s	_{p=0.461 n=6}
_{Total Time}	_{25.26s (± 0.37%)}	_{25.29s (± 0.46%)}	_~	_25.13s	_25.48s	_{p=0.873 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,320k (± 0.01%)}	_{371,386k (± 0.04%)}	_~	_371,251k	_371,638k	_{p=0.298 n=6}
_{Parse Time}	_{2.88s (± 1.53%)}	_{2.90s (± 1.22%)}	_~	_2.84s	_2.95s	_{p=0.571 n=6}
_{Bind Time}	_{1.58s (± 0.76%)}	_{1.61s (± 1.56%)}	_~	_1.58s	_1.65s	_{p=0.073 n=6}
_{Check Time}	_{16.48s (± 0.37%)}	_{16.49s (± 0.28%)}	_~	_16.42s	_16.54s	_{p=0.689 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{20.95s (± 0.37%)}	_{20.99s (± 0.36%)}	_~	_20.86s	_21.06s	_{p=0.297 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,231,203	_3,231,203	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,095,687	_1,095,687	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,308,135k (± 0.01%)}	_{3,308,308k (± 0.01%)}	_~	_3,307,710k	_3,308,559k	_{p=0.378 n=6}
_{Parse Time}	_{14.29s (± 0.64%)}	_{14.27s (± 0.45%)}	_~	_14.20s	_14.36s	_{p=0.630 n=6}
_{Bind Time}	_{4.58s (± 1.14%)}	_{4.56s (± 0.47%)}	_~	_4.54s	_4.60s	_{p=0.570 n=6}
_{Check Time}	_{87.59s (± 0.36%)}	_{88.83s (± 2.16%)}	_~	_86.73s	_92.08s	_{p=0.173 n=6}
_{Emit Time}	_{27.97s (± 2.27%)}	_{27.53s (± 2.52%)}	_~	_26.97s	_28.90s	_{p=0.093 n=6}
_{Total Time}	_{134.44s (± 0.58%)}	_{135.20s (± 1.55%)}	_~	_132.44s	_138.20s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_293,866	_293,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_119,628	_119,628	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{447,141k (± 0.03%)}	_{447,210k (± 0.02%)}	_~	_447,031k	_447,331k	_{p=0.471 n=6}
_{Parse Time}	_{4.09s (± 0.97%)}	_{4.08s (± 0.77%)}	_~	_4.04s	_4.12s	_{p=0.465 n=6}
_{Bind Time}	_{1.78s (± 1.20%)}	_{1.76s (± 1.42%)}	_~	_1.73s	_1.79s	_{p=0.292 n=6}
_{Check Time}	_{18.78s (± 0.66%)}	_{18.84s (± 0.41%)}	_~	_18.74s	_18.93s	_{p=0.378 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.65s (± 0.55%)}	_{24.68s (± 0.34%)}	_~	_24.59s	_24.82s	_{p=0.686 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_560,868	_560,868	_~	_~	_~	_{p=1.000 n=6}
_Types	_187,848	_187,848	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{497,767k (± 0.02%)}	_{497,728k (± 0.04%)}	_~	_497,454k	_497,868k	_{p=0.936 n=6}
_{Parse Time}	_{3.44s (± 0.50%)}	_{3.43s (± 1.03%)}	_~	_3.40s	_3.47s	_{p=0.744 n=6}
_{Bind Time}	_{1.20s (± 1.01%)}	_{1.19s (± 1.26%)}	_~	_1.17s	_1.21s	_{p=0.805 n=6}
_{Check Time}	_{19.72s (± 0.56%)}	_{19.72s (± 0.34%)}	_~	_19.65s	_19.83s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.36s (± 0.43%)}	_{24.35s (± 0.33%)}	_~	_24.27s	_24.49s	_{p=0.873 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-02-24T20:14:34Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61177/merge:

Everything looks good!

Treat functions with @type tags on parameters as typed in JS files

945556d

Merge remote-tracking branch 'origin/main' into fix/typed-functions-w…

ec3cb37

…ith-type-on-params

jakebailey approved these changes Feb 25, 2025

View reviewed changes

jakebailey requested a review from sandersn February 25, 2025 02:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Treat functions with `@type` tags on parameters as typed in JS files #61177

Treat functions with `@type` tags on parameters as typed in JS files #61177

Andarist commented Feb 14, 2025

jakebailey commented Feb 22, 2025

Andarist commented Feb 22, 2025

jakebailey commented Feb 24, 2025

typescript-bot commented Feb 24, 2025 •

edited

Loading

typescript-bot commented Feb 24, 2025

typescript-bot commented Feb 24, 2025

typescript-bot commented Feb 24, 2025

tsc

typescript-bot commented Feb 24, 2025

Treat functions with @type tags on parameters as typed in JS files #61177

Are you sure you want to change the base?

Treat functions with @type tags on parameters as typed in JS files #61177

Conversation

Andarist commented Feb 14, 2025

jakebailey commented Feb 22, 2025

Andarist commented Feb 22, 2025

jakebailey commented Feb 24, 2025

typescript-bot commented Feb 24, 2025 • edited Loading

typescript-bot commented Feb 24, 2025

typescript-bot commented Feb 24, 2025

typescript-bot commented Feb 24, 2025

tsc

typescript-bot commented Feb 24, 2025

Treat functions with `@type` tags on parameters as typed in JS files #61177

Treat functions with `@type` tags on parameters as typed in JS files #61177

typescript-bot commented Feb 24, 2025 •

edited

Loading