Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeFix and Diagnostic for Unnecessary Named Import #61219

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

CodeFix and Diagnostic for Unnecessary Named Import #61219

wants to merge 6 commits into from
+129 −0

Conversation

sidlamsal
Copy link

Fixes #56497

@sidlamsal
Copy link
Author

@microsoft-github-policy-service agree

@sidlamsal sidlamsal marked this pull request as ready for review February 18, 2025 19:26
@jakebailey
Copy link
Member

This PR says it fixes #56497, but that's not entirely the case; #56497 is asking for rename to not introduce foo as foo at all, whereas this PR adds a new suggestion that complains about foo as foo. That's a fine suggestion, but I would expect a PR that fixes #56497 to fix rename, and IIRC there's something odd about the way renaming works that may prevent that from working (but I can't remember what it was; I've wanted to fix this issue previously but gave up due to some issue...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Rename symbol command] Remove unnecessary named import
3 participants
@sidlamsal @jakebailey @calebloring