Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating MySql configuration for Optimization #419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updating MySql configuration for Optimization #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/VirtualClient/VirtualClient.Main/profiles/PERF-MYSQL-SYSBENCH-OLTP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"DatabaseName": "sbtest",
"DatabaseScenario": "Balanced",
"DiskFilter": "osdisk:false&sizegreaterthan:256g",
"InnodbBufferPoolSize": "{calculate({SystemMemoryBytes} * 80 / 100)}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you change profile parameters please change document accordingly.

"Duration": "00:05:00"
},
"Actions": [
Expand Down Expand Up @@ -169,7 +170,7 @@
"Parameters": {
"Scenario": "DownloadMySqlServerPackage",
"BlobContainer": "packages",
"BlobName": "mysql-server-8.0.36.zip",
"BlobName": "mysql-server-8.0.36-v2.zip",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the changes, need to document what you changed in the package. Also there might be licensing concerns if we modify mysql package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the changes not done to mysql package directly. There are few python scripts we have developed in order to configure and run mysql. I will document the changes made. I was planning to add those scripts in source code too, inorder to have proper version control.

"PackageName": "mysql-server",
"Extract": true,
"Role": "Server"
Expand Down Expand Up @@ -231,7 +232,8 @@
"Action": "SetGlobalVariables",
"Benchmark": "OLTP",
"DiskFilter": "$.Parameters.DiskFilter",
"Variables": "MAX_PREPARED_STMT_COUNT=1000000;MAX_CONNECTIONS=1000000",
"InnodbBufferPoolSize": "$.Parameters.InnodbBufferPoolSize",
"Variables": "MAX_PREPARED_STMT_COUNT=655350;MAX_CONNECTIONS=10000;innodb_buffer_pool_size={InnodbBufferPoolSize};innodb_lock_wait_timeout=300;innodb_io_capacity=10000;innodb_io_capacity_max=10000;innodb_buffer_pool_dump_at_shutdown=OFF;innodb_change_buffering=0;table_open_cache=20000;",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to document all these default varaibles. If they are compete specific, create an internal compete profile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not specifically for compete. This is optimization for mysql itself. These values help in increasing efficiency of mysql ( observed improved time in database creation).

"PackageName": "mysql-server",
"Role": "Server"
}
Expand Down
Loading